Repository navigation
fix: default MiniMax configurations to M3.1 Flash - #2521
Open
octo-patch wants to merge 2 commits into
Open
octo-patch wants to merge 2 commits into
octo-patch wants to merge 2 commits into
Conversation
Collaborator
🤖 Open Code ReviewTarget: PR #2521 🔍 OpenCodeReview found 2 issue(s) in this PR. 1.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason: Use MiniMax-M3.1-Flash for new MiniMax configurations while preserving explicitly selected models.
Description
The unset
MOS_CHAT_MODELfallback still selects MiniMax-M2.7. Change that fallback toMiniMax-M3.1-Flashand refresh the ordinary example to list Flash first and MiniMax-M3 as the alternative. Explicit environment values, saved configurations, per-request model overrides, custom endpoints, legacy models, tools and message history remain unchanged. No dependencies or protocol routes change.Related Issue: No matching open issue identified. Historical context: #1859 was automatically closed for inactivity. This is separate from the video-input work in #2452.
Model reference: https://platform.minimax.io/docs/guides/models-intro.md
The contribution guide names
dev, but that branch currently returns 404; this PR targets the live default branch,main.Type of change
How Has This Been Tested?
tests/llms/test_minimax_requests.pycontains 27 offline cases at the real SDK/HTTPX transport boundary, covering streaming and non-streaming defaults, saved M3/legacy/custom IDs, configured endpoints, request overrides, explicit thinking/effort, images, tools and reasoning/tool history.ruff check --no-cache --no-fixandruff format --no-cache --checkpass.git diff --checkpasses.make format,make openapiandmake pre_commitcannot run because Poetry is unavailable. Heavy dependency setup is paused under the workspace resource gate. The queued lightweight SDK setup was canceled before installing anything after remote CI became available. The equivalent pinned Ruff checks above ran directly. Current-head repository CI at https://github.com/MemTensor/MemOS/actions/runs/39422915565 has passed all four Linux Python versions (3.10–3.13) and macOS 14 Python 3.11/3.12, including the pytest-with-coverage steps. Ten remaining matrix jobs were queued or running at the latest check; the full matrix is not yet complete.Checklist
Reviewer Checklist