Repository navigation
get_default_cube_config: clear ValueError instead of UnboundLocalError for invalid text_mem_type - #2442
get_default_cube_config: clear ValueError instead of UnboundLocalError for invalid text_mem_type#2442simpleqt wants to merge 1 commit into
Conversation
get_default_cube_config only assigned text_mem_config inside the tree_text/general_text branches, so any other value crashed with a bare UnboundLocalError. Fixes MemTensor#2441
🤖 Open Code ReviewTarget: PR #2442 ✅ OpenCodeReview: Review complete: 0 finding(s) across 2 selected item(s). Generated by cloud-assistant via Open Code Review. |
✅ Automated Test Results: PASSEDAll tests passed (5/5 executed). memos_python_core/changed-repo-python: 5/5. Duration: 8s [advisory, non-gating] AI-generated tests on branch test/auto-gen-a63e2db40c11703c-20260930220428: 44/44 passed — these do NOT affect the PR verdict; review the branch manually. Branch: |
|
This PR has been automatically marked as stale due to inactivity. |
|
Closing this to get my open pull requests in this repository down to a sane number: I had 8 open here at once, which is more than anyone should be asked to review. The branch stays in my fork if it is ever useful - happy to reopen on request. |
Fixes #2441
Summary
get_default_cube_configinsrc/memos/mem_os/utils/default_config.pyonly assignstext_mem_configinside thetree_textandgeneral_textbranches, with noelse. Any other value — e.g. a typo like"tree-text"reaching the config plumbing — crashes with a bareUnboundLocalError:Fix
Add the missing
elsebranch raising a clear error that names the accepted values:Regression test
Added
tests/mem_os/test_default_config_text_mem_type.py:UnboundLocalError) and pass with the fixruff check(repo-pinned 0.11.8) passes on both touched files.AI Disclosure