Skip to content

docs(examples): drop the orphaned NLI e2e example - #2389

Closed
simpleqt wants to merge 1 commit into
MemTensor:mainfrom
simpleqt:sq919/nli-orphan
Closed

simpleqt wants to merge 1 commit into
MemTensor:mainfrom
simpleqt:sq919/nli-orphan

Conversation

@simpleqt

Copy link
Copy Markdown

examples/extras/nli_e2e_example.py imports:

from memos.extras.nli_model.client import NLIClient
from memos.extras.nli_model.server.serve import app

but memos.extras.nli_model was deleted in the hook-based plugin-system refactor (#1533) and does not exist anywhere else in the tree (or in apps/memos-local-plugin). The example therefore raises ImportError on run, and it is the only file in examples/extras/.

Related Issue: N/A (dead-code cleanup after #1533)

examples/extras/nli_e2e_example.py imports memos.extras.nli_model, which
was deleted in the hook-based plugin refactor (MemTensor#1533) and no longer lives
anywhere in the tree (or the memos-local plugin). The example raises
ImportError on run, and it is the only file in examples/extras/.
Copilot AI lite review requested due to automatic review settings September 19, 2026 08:00
@Memtensor-AI Memtensor-AI added area:core MOS 编排层 / 框架底座 / 跨模块问题 status:in-progress Someone or AI is working on it | 人工或 AI 正在处理 labels Sep 19, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@Memtensor-AI

Copy link
Copy Markdown
Collaborator

🤖 Open Code Review

Target: PR #2389
Task: 5218ccfa829dce20
Base: main
Head: sq919/nli-orphan

✅ OpenCodeReview: Review skipped: no items were selected.

Generated by cloud-assistant via Open Code Review.

@Memtensor-AI

Copy link
Copy Markdown
Collaborator

✅ Automated Test Results: PASSED

All tests passed (1/1 executed). memos_github_open_source/smoke: 1/1. Duration: 1s

Branch: sq919/nli-orphan

@Memtensor-AI Memtensor-AI added status:ready Ready for implementation; waiting for assignee or AI dispatch | 可进入实现,等待认领或派发 and removed status:in-progress Someone or AI is working on it | 人工或 AI 正在处理 labels Sep 19, 2026
@github-actions

Copy link
Copy Markdown
Contributor

This PR has been automatically marked as stale due to inactivity.

@github-actions github-actions Bot added the status:stale Auto-marked stale after 30d inactivity; closes 7d later unless exempt. label Oct 22, 2026
@simpleqt

simpleqt commented Nov 9, 2026

Copy link
Copy Markdown
Author

Closing this to get my open pull requests in this repository down to a sane number: I had 8 open here at once, which is more than anyone should be asked to review. The branch stays in my fork if it is ever useful - happy to reopen on request.

@simpleqt simpleqt closed this Nov 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:core MOS 编排层 / 框架底座 / 跨模块问题 status:ready Ready for implementation; waiting for assignee or AI dispatch | 可进入实现,等待认领或派发 status:stale Auto-marked stale after 30d inactivity; closes 7d later unless exempt.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants