Repository navigation
Fix #1679: fix: The timed_with_status method was swallowing exceptions, making debugging di - #1883
Memtensor-AI wants to merge 2 commits into
Conversation
The timed_with_status decorator was swallowing exceptions when no fallback was provided, making debugging difficult. This fix adds an explicit 'else: raise' clause to re-raise exceptions when fallback is None or not provided. Changes: - src/memos/utils.py: Added else clause to re-raise exceptions - tests/test_utils_timing.py: Added test cases to verify exception propagation Fixes #1679
✅ Automated Test Results: PASSEDAll tests passed (35/35 executed, 36 skipped). memos_local_plugin/smoke: 0 passed, 1 skipped, memos_local_plugin/contract: 35 passed, 35 skipped. Duration: 4s Branch: |
🤖 Open Code ReviewTarget: PR #1883 🔍 OpenCodeReview found 1 issue(s) in this PR. 1.
|
Description
Fixed the bug in timed_with_status decorator where exceptions were being swallowed when no fallback was provided.
Root Cause: The decorator's except block caught exceptions but only returned a fallback result when a fallback function was provided. When no fallback existed, the exception was silently suppressed, causing the decorated function to return None instead of propagating the error.
Fix: Added an explicit
else: raiseclause after the fallback check to re-raise the exception when no fallback is provided. This preserves the decorator's timing and logging functionality while ensuring exceptions propagate correctly for debugging.Changes:
Testing: Created and ran a standalone verification script that confirmed:
This fix resolves the debugging difficulty reported in issue #1679 where incorrect API keys or URLs would fail silently instead of raising clear exceptions.
Related Issue (Required): Fixes #1679
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Executor did not report tests.
Checklist
@MatthewZhuang, @CarltonXiang, @syzsunshine219 please review this PR.
Reviewer Checklist