Repository navigation
Conversation
… large databases
Migration 007 (namespace-visibility) runs UPDATE ... SET share_scope
and CREATE INDEX on the traces table inside a single db.tx(). On
databases larger than ~500MB, this exceeds the host gateway kill
timeout, SQLite rolls back the entire transaction (including the
schema_migrations INSERT), and the bridge restarts into the same
hang forever.
This splits the migration into two phases:
Phase 1 (inside transaction, ms): ADD COLUMN only on 12 namespace
tables plus DROP INDEX uq_skills_name. The schema_migrations
record commits here.
Phase 2 (after migration loop, outside any transaction): Batched
UPDATE in 2,000-row chunks (each its own implicit transaction)
for share_scope backfill, then CREATE INDEX IF NOT EXISTS for
all 18 owner/share indexes. Phase 2 also calls
ensureNamespaceColumns unconditionally so new tables added to
the namespace list get their columns on every boot.
Restart-safe: if the bridge is killed during Phase 2, the v7
schema_migrations record survives (Phase 1 committed). Next boot
skips Phase 1 entirely and resumes Phase 2 where it left off.
Closes MemTensor#1787
docs(memos-local-plugin): clarify install path and stale dir names (MemTensor#1540) The README's 'Quick start' section told users to use install.sh instead of npm install, but the warning was buried and users still tried 'npm install -g @memtensor/memos-local-plugin' first. The reporter in MemTensor#1540 encountered this on a Hermes deployment. This change: - Promotes the 'do not run npm install -g' notice to a prominent IMPORTANT callout explaining why global install is wrong (no agent-home deploy, no config.yaml, no bridge/viewer) and that the tarball intentionally ships built artifacts only. - Adds a Troubleshooting subsection covering the two specific symptoms in the bug report: the 'package not found' misread, and the stale web/ and site/ directory names (web/ is now viewer/, site/ was removed by commit 26e7e3d). - Mentions install.ps1 for Windows alongside install.sh. - CHANGELOG: record the docs fix and reference MemTensor#1540. Documentation-only change; no code or runtime behavior touched. Co-authored-by: MemOS AutoDev <autodev@memtensor.ai> Co-authored-by: Matthew <heimixiaozhuang@zju.edu.cn>
…_() got an unexpected keyword a (MemTensor#1889) fix: remove invalid chunker parameter from SystemParser test instantiation - SystemParser.__init__() signature changed to (embedder, llm=None) - Test was still passing chunker=None causing TypeError - Fixes all 5 failing tests in test_system_parser.py Fixes MemTensor#1888 Co-authored-by: MemOS AutoDev <autodev@memos.ai> Co-authored-by: Matthew <heimixiaozhuang@zju.edu.cn>
…tributeError when given None (MemTensor#1884) * test: add comprehensive tests for clean_json_response (issue MemTensor#1525) - Add test suite in tests/mem_os/test_format_utils.py - Cover None input ValueError with diagnostic message - Cover markdown removal, whitespace stripping, edge cases - Verify fix for AttributeError when LLM returns None * style: format clean_json_response tests --------- Co-authored-by: MemOS AutoDev <autodev@memos.ai> Co-authored-by: Matthew <heimixiaozhuang@zju.edu.cn>
…date_cube_access — fails for ev (MemTensor#1903) fix: validate current user not target in share_cube_with_user (MemTensor#1901) share_cube_with_user(cube_id, target_user_id) called _validate_cube_access(cube_id, target_user_id), but the validator signature is (user_id, cube_id). The cube_id therefore landed in the user_id slot and _validate_user_exists raised "User '<cube_id>' does not exist or is inactive" for every well-formed call, making the API unusable. The in-code comment "Validate current user has access to this cube" already documented the correct intent: the sharing user (self.user_id) must have access to the cube being shared, not the target. Switch the call to self._validate_cube_access(self.user_id, cube_id). The target user's existence is independently checked on the next line via validate_user(target_user_id), so that path is unchanged. Add regression tests in tests/mem_os/test_memos_core.py that pin down: - validate_user_cube_access is consulted with (self.user_id, cube_id), - add_user_to_cube is called with (target_user_id, cube_id) on success, - a missing target raises "Target user '<id>' does not exist". Closes MemTensor#1901 Co-authored-by: MemOS AutoDev Bot <autodev@memtensor.local> Co-authored-by: Matthew <heimixiaozhuang@zju.edu.cn>
|
Automated Test Results: FAILED Cloud test-engine rerun against
Failed cases:
❯ tests/unit/storage/traces-count.test.ts:76:27 ⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[1/1]⎯ Do not merge until this is fixed and cloud tests pass. |
|
Thanks for the genuinely thorough investigation here, @chiefmojo — the bisect table, the 687MB repro, and the root-cause write-up on the migration-007 transaction timeout are all excellent and much appreciated. I'm going to close this PR, because the crash-loop it targets (#1787) has already been fixed on The merged fix took a simpler route to the same goal:
Given that, this PR can't be merged as-is:
If you think the one piece of net-new hardening here is still worth having — moving One more thing that surfaced while digging into this: the #1787 regression test on Thanks again for the deep debugging here — it genuinely helped confirm the root cause. |
Problem
Migration 007 (namespace-visibility) in v2.0.2–v2.0.5 runs
UPDATE … SET share_scope='private'plusCREATE INDEXon the traces table inside a singledb.tx(). On databases larger than ~500MB, this exceeds the host gateway's kill timeout. SQLite rolls back the entire transaction — including theschema_migrationsINSERT — so migration 007 is never recorded and the bridge restarts into the same hang forever.Small databases (~43MB) complete within the timeout, which is why this only manifests on larger installs. Tested against a 687MB database with ~98,000 traces.
Fix
Two-phase migration:
ADD COLUMNonly on all 12 namespace tables, plusDROP INDEX uq_skills_name. Theschema_migrationsrecord for v7 commits here.UPDATEin 2,000-row chunks (each its own implicit transaction) forshare_scopebackfill, thenCREATE INDEX IF NOT EXISTSfor all 18 owner/share indexes.ensureNamespaceColumnsis called unconditionally on every boot so new tables in the namespace list get their columns.Restart safety: If the bridge is killed during Phase 2, the v7
schema_migrationsrecord survives (Phase 1 committed). Next boot skips Phase 1 entirely and resumes Phase 2 where it left off. The crash-loop is broken.Verification
pipeline.ready.Related
Closes #1787