You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix: The automated PR #2406 for this issue was closed without being merged, and its branch (bugfix/autodev-2405-20260924123345867) has since been deleted, so the fix never landed: #2407
Commit 5f5d63f2 ("fix: upgrade DSH adapter message sources to session format v4") exists but is not contained in any branch
dev-v2.0.36 and main still contain source: { kind: "plugin", plugin: ... } at adapters/deepseek-harness/index.ts:390 and host-llm.ts:369
npm @memtensor/memos-local-plugin is still 2.0.20, so users have no fixed release to install
The commit content itself looked correct — both message sources were moved to kind: `plugin:<producer>` with the plugin field removed — so could it be re-submitted or merged manually?
One note for whoever picks this up: the Open Code Review finding about host-llm.ts needing a form property does not apply. The DSH v4 admission check only requires source.kind to be a non-empty string other than "plugin" (see source() in @deepseek-ai/dsh-session-format-v3-to-v4), and this plugin's own message filters match on source.kind === "user", so adding form is unnecessary.
How to Reproduce | 如何重现
1.Install DSH 0.1.7-rc.1 and enable @memtensor/memos-local-plugin@2.0.20 in a profile's dsh.profile.bundles.
2.Start dsh web and open a session that has at least one memory hit, so the agent/pre-step recall injection fires.
3.Send any message → the turn fails immediately with the error above.
The session log stops right after turn/start, i.e. during agent/pre-step, before any assistant output is produced. Every later message fails the same way.
Reverting DSH to 0.1.5-rc.2 with no plugin change fixes it immediately, which points at the source-kind shape rather than at the recall logic itself.
Environment | 环境信息
Python version: not applicable — this report concerns the DeepSeek Harness adapter (adapters/deepseek-harness/), not the Python package.
Operating System: Windows 11
MemOS version (pip show memoryos): not applicable; plugin version is @memtensor/memos-local-plugin@2.0.20 (current npm latest)
Node.js: v24.20.0
DSH: 0.1.7-rc.1 (the release that ships @deepseek-ai/dsh-session-format-v3-to-v4 and the v4 admission check). Reproduces on 0.1.7-rc.1; does not reproduce on 0.1.5-rc.2.
Additional Context | 其他信息
No response
Willingness to Implement | 实现意愿
I'm willing to implement this myself | 我愿意自己解决
I would like someone else to implement this | 我希望其他人来解决
+1 on getting #2406 re-submitted or merged manually — a third independent environment (macOS, official DSH desktop 0.1.7-rc.2, profile desktop).
I reproduced the conditional trigger, settled the form question by running the host's real source() extracted from app.asar (result: plugin/form are both optional; only kind !== "plugin" matters), and verified the #2406 change end-to-end on a real install: after patching the two shipped dist files and restarting DSH, a recall-injected turn now persists user/message with source: {"kind":"plugin:memos-local-memory","form":"recall"} (the exact write path that used to throw). Full details: #2405 (comment)
Re-checked today (2026-09-28): main still has index.ts:390-391 and host-llm.ts:369 on the retired kind: "plugin" shape, and npm latest is still 2.0.20, so there is still no fixed release to install.
Thanks for following up and confirming the failure across environments. The V4 message-source fix tracked in #2405 landed through #2519 and shipped in @memtensor/memos-local-plugin@2.0.21. This covers both recall messages and auxiliary host LLM messages.
For supported DSH 0.2 previews, use @memtensor/memos-local-plugin@2.0.21-beta.1, which also includes the startup compatibility fix from #2549.
Activity
VillagerUncle02 commentedon Sep 24, 2026
独立确认:修复确实还没落地,问题仍可复现。
0.1.7-rc.2(npmnext)+@memtensor/memos-local-plugin@2.0.20(npm latest),Windows 11main上apps/memos-local-plugin/adapters/deepseek-harness/index.ts(createRecallMessage)与host-llm.ts(toDshMessage)仍是kind: "plugin"turn/start、以及一个保留plugin字段也能通过 V4 门禁的写法)见 fix: DSH 0.1.7 (session format v4) rejects memos recall messages — "format v4 message requires a producer-owned source kind" #2405 的最新评论@Pasitearko 上面问的"能否重新提交/手工合并 #2406"同样适用于这里 —— 有修复版发布后我会撤掉本地补丁。
lby9201-arch commentedon Sep 28, 2026
+1 on getting #2406 re-submitted or merged manually — a third independent environment (macOS, official DSH desktop
0.1.7-rc.2, profiledesktop).I reproduced the conditional trigger, settled the
formquestion by running the host's realsource()extracted fromapp.asar(result:plugin/formare both optional; onlykind !== "plugin"matters), and verified the #2406 change end-to-end on a real install: after patching the two shippeddistfiles and restarting DSH, a recall-injected turn now persistsuser/messagewithsource: {"kind":"plugin:memos-local-memory","form":"recall"}(the exact write path that used to throw). Full details: #2405 (comment)Re-checked today (2026-09-28):
mainstill hasindex.ts:390-391andhost-llm.ts:369on the retiredkind: "plugin"shape, and npmlatestis still2.0.20, so there is still no fixed release to install.endxxxx commentedon Nov 9, 2026
Thanks for following up and confirming the failure across environments. The V4 message-source fix tracked in #2405 landed through #2519 and shipped in
@memtensor/memos-local-plugin@2.0.21. This covers both recall messages and auxiliary host LLM messages.For supported DSH 0.2 previews, use
@memtensor/memos-local-plugin@2.0.21-beta.1, which also includes the startup compatibility fix from #2549.Closing this follow-up as a duplicate of #2405.