Skip to content

fix: The automated PR #2406 for this issue was closed without being merged, and its branch (bugfix/autodev-2405-20260924123345867) has since been deleted, so the fix never landed: #2407

Closed

Description

@Pasitearko

Pre-submission checklist | 提交前检查

  • I have searched existing issues and this hasn't been mentioned before | 我已搜索现有问题,确认此问题尚未被提及
  • I have read the project documentation and confirmed this issue doesn't already exist | 我已阅读项目文档并确认此问题尚未存在
  • This issue is specific to MemOS and not a general software issue | 该问题是针对 MemOS 的,而不是一般软件问题

Bug Description | 问题描述

  • PR Fix #2405: fix: DSH 0.1.7 (session format v4) rejects memos recall messages — "format v4 me #2406: state closed, merged: false — closed 12:49:13Z, one second after Open Code Review asked for a follow-up fix
  • Commit 5f5d63f2 ("fix: upgrade DSH adapter message sources to session format v4") exists but is not contained in any branch
  • dev-v2.0.36 and main still contain source: { kind: "plugin", plugin: ... } at adapters/deepseek-harness/index.ts:390 and host-llm.ts:369
  • npm @memtensor/memos-local-plugin is still 2.0.20, so users have no fixed release to install

The commit content itself looked correct — both message sources were moved to kind: `plugin:<producer>` with the plugin field removed — so could it be re-submitted or merged manually?

One note for whoever picks this up: the Open Code Review finding about host-llm.ts needing a form property does not apply. The DSH v4 admission check only requires source.kind to be a non-empty string other than "plugin" (see source() in @deepseek-ai/dsh-session-format-v3-to-v4), and this plugin's own message filters match on source.kind === "user", so adding form is unnecessary.

How to Reproduce | 如何重现

1.Install DSH 0.1.7-rc.1 and enable @memtensor/memos-local-plugin@2.0.20 in a profile's dsh.profile.bundles.

2.Start dsh web and open a session that has at least one memory hit, so the agent/pre-step recall injection fires.

3.Send any message → the turn fails immediately with the error above.

The session log stops right after turn/start, i.e. during agent/pre-step, before any assistant output is produced. Every later message fails the same way.

Reverting DSH to 0.1.5-rc.2 with no plugin change fixes it immediately, which points at the source-kind shape rather than at the recall logic itself.

Environment | 环境信息

Python version: not applicable — this report concerns the DeepSeek Harness adapter (adapters/deepseek-harness/), not the Python package.

Operating System: Windows 11

MemOS version (pip show memoryos): not applicable; plugin version is @memtensor/memos-local-plugin@2.0.20 (current npm latest)

Node.js: v24.20.0

DSH: 0.1.7-rc.1 (the release that ships @deepseek-ai/dsh-session-format-v3-to-v4 and the v4 admission check). Reproduces on 0.1.7-rc.1; does not reproduce on 0.1.5-rc.2.

Additional Context | 其他信息

No response

Willingness to Implement | 实现意愿

  • I'm willing to implement this myself | 我愿意自己解决
  • I would like someone else to implement this | 我希望其他人来解决

Activity

  1. added
    status:needs-triageNeeds initial triage | 需要初步判断 & 问题复现
    types:bugSomething isn't working | 功能异常
    on Sep 24, 2026
  2. VillagerUncle02 commented on Sep 24, 2026

    @VillagerUncle02

    独立确认:修复确实还没落地,问题仍可复现。

    @Pasitearko 上面问的"能否重新提交/手工合并 #2406"同样适用于这里 —— 有修复版发布后我会撤掉本地补丁。

  3. lby9201-arch commented on Sep 28, 2026

    @lby9201-arch

    +1 on getting #2406 re-submitted or merged manually — a third independent environment (macOS, official DSH desktop 0.1.7-rc.2, profile desktop).

    I reproduced the conditional trigger, settled the form question by running the host's real source() extracted from app.asar (result: plugin/form are both optional; only kind !== "plugin" matters), and verified the #2406 change end-to-end on a real install: after patching the two shipped dist files and restarting DSH, a recall-injected turn now persists user/message with source: {"kind":"plugin:memos-local-memory","form":"recall"} (the exact write path that used to throw). Full details: #2405 (comment)

    Re-checked today (2026-09-28): main still has index.ts:390-391 and host-llm.ts:369 on the retired kind: "plugin" shape, and npm latest is still 2.0.20, so there is still no fixed release to install.

  4. endxxxx commented on Nov 9, 2026

    @endxxxx
    Collaborator

    Thanks for following up and confirming the failure across environments. The V4 message-source fix tracked in #2405 landed through #2519 and shipped in @memtensor/memos-local-plugin@2.0.21. This covers both recall messages and auxiliary host LLM messages.

    For supported DSH 0.2 previews, use @memtensor/memos-local-plugin@2.0.21-beta.1, which also includes the startup compatibility fix from #2549.

    Closing this follow-up as a duplicate of #2405.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

area:pluginOpenClaw & Hermesstatus:needs-triageNeeds initial triage | 需要初步判断 & 问题复现types:bugSomething isn't working | 功能异常

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions