Correct v0.13.0 docs and ignore the video draft - #87
Merged
Conversation
PRs #80, #81 and #82 shipped a working in-panel model downloader inside the v0.13.0-alpha tag -- src/comfy/modelDownload.ts, src/ui/setupInstallModel.ts and the wiring in src/ui/App.ts -- and the feature flag that had gated it is gone. Every published document still said the Setup screen only reports and copies, which is the worst kind of wrong: it tells a tester not to look for the thing they most need. The withheld-assisted-install paragraph moves out of Known limitations and becomes an Added entry describing what it actually does -- direct download from the registry's own pinned URLs, resumable 8 MiB chunks, one model at a time, behind a confirmation naming size, destination and host. Every licence gate and repo-folder refusal is described as still in force, because it is; what is genuinely still manual is named rather than implied. docs/become-a-tester.html also gets the v0.13.0 pass it never received. It was frozen at v0.12.0 in seven places, the second release running that it went stale, so docs/release-checklist.md now lists it as a version location with a note on why reading it is not enough. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
openExternalUrl and the data-openlayer-external delegated handler have been in appBindings.ts since v0.13.0 with no caller: nothing in src/ ever emitted the attribute, so the plumbing was built, tested by nobody, and dead. This gives it the two callers it was written for. Setup rows gain an Open button beside Copy Link. Copy Link stays -- it is the only thing that still works when the host refuses to open a URL, and Copy Folder Path was never a link to begin with. The button is built from sourcePageUrl and never from downloadUrl, because handing a download URL to a browser starts fetching the file and several of these are tens of gigabytes; a row with no source page gets no button rather than an Open that does something its label does not say. Workflow Health rows had no link to offer at all, so the issue that produces a row now carries the page that answers it: the repository for a missing custom node, the model card for a missing model. Two cases deliberately produce no button. A node absent from CUSTOM_NODE_PACKAGES is core ComfyUI, where there is nothing to install and so nothing to open. A model found in the wrong folder needs moving, not fetching, and a link there would only invite a second copy of a file already on disk. openExternalUrl now reports whether either route ran. It could fail silently before -- UXP's shell can reject and the Photoshop host has no working window.open -- and the log line claimed success before the shell had answered, which would have been the only evidence available when someone reported that nothing happened. window.open is now guarded as well as feature-checked, so a throwing host cannot reject a promise nothing awaits. Eight tests cover the offer logic on both screens, including every case that deliberately produces no button. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
docs/video-01-intro-shooting-script.md is a personal production doc, not part of the product; keep it out of the tracked tree. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com