Skip to content

fix: reply to the legacy PIN request instead of letting the pair hang #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MegaManSec merged 1 commit into from
Aug 20, 2026
Merged

fix: reply to the legacy PIN request instead of letting the pair hang #110

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion Magic Switch/Model/Store/BluetoothPeripheralStore.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1568,7 +1568,21 @@ final class BluetoothPeripheralStore: NSObject, ObservableObject, BluetoothPerip
else {
return
}
print("Bluetooth pairing requested a PIN code for \(address)")
DispatchQueue.main.async { [weak self] in
guard let self = self else { return }
guard self.pendingPairs[address] === pair else {
print("Ignoring Bluetooth PIN code request for \(address): not our pairing")
return
}
print("Replying to Bluetooth PIN code request for \(address)")
// Legacy HID peripherals with no keypad take the all-zero PIN.
var code = BluetoothPINCode()
let digits = Array("0000".utf8)
withUnsafeMutableBytes(of: &code.data) { raw in
for (index, byte) in digits.enumerated() { raw[index] = byte }
}
pair.replyPINCode(digits.count, pinCode: &code)
}
}

/// Selector target for `IOBluetoothDevice.register(forDisconnectNotification:...)`.
Expand Down
Loading