the value of ref in JSON escapes backslashes.#818
Open
henryborchers wants to merge 2 commits into
Open
Conversation
When using a Windows machine, the backslash file paths make json exports invalid json format in "ref"
Contributor
Author
|
This looks like there is a file generation part in this that turns Source/Resource/displays/MediaConchJson.xsl into Source/Common/generated/ImplementationReportDisplayJsonXsl.h. I'm not sure what is being done here. |
Signed-off-by: Maxime Gervais <gervais.maxime@gmail.com>
Contributor
Author
|
The Unix tests seem to be failing for reasons that are not related to these changes. on the Mac test, libevent doesn't look like it's installed and it's expecting it to be. Edit: I found it in Project/GNU/CLI/test/test_mk.sh. But the failure still seems unrelated to my changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using a Windows machine, the backslash file paths make json exports invalid json format in "ref"