Initial poll implementation by BentiGorlich · Pull Request #2113 · MbinOrg/mbin

BentiGorlich · 2026-04-23T17:01:34Z

add the ability to add a poll to Entry, EntryComment, Post and PostComment
Polls:
- can be multiple choice
- can contain an unlimited number of choices
- can expire
Add a hidden form for the poll to all create forms, the form appears when a checkbox is checked
The ActivityPub implementation is the same as on Mastodon: https://docs.joinmastodon.org/spec/activitypub/#Question
Add tests for the ActivityPub implementation and the Api controller
The api had to be shifted a bit -> the serialize... functions in the base api take only the entity classes now instead of their dto variant -> touched a lot of api classes because of this

Images:

Each create form (Thread, Microblog, Comments) now have this checkbox to add a poll:

When checked it looks like this:

Once created it looks like this:

If you have voted it looks like this:

Closes #647

BentiGorlich · 2026-04-23T17:08:16Z

Open things:

This does not yet send an Update activity upon a new vote, which I though Mastodon also doesn't do, but there is an fep for this that was also mentioned in the issue and it says that an implementation should do it: https://codeberg.org/silverpill/feps/src/branch/main/9967/fep-9967.md
it does not yet use the closed property, which it should do if endTime is not provided
the Poll AP object does not yet have an updated field.
All in all some AP stuff has to be done
one cannot yet manually refresh the results
one cannot yet jump to the results without voting

- add the ability to add a poll to Entry, EntryComment, Post and PostComment - Polls: - can be multiple choice - can contain an unlimited number of choices - can expire - Add a hidden form for the poll to all create forms, the form appears when a checkbox is checked - The ActivityPub implementation is the same as on Mastodon: https://docs.joinmastodon.org/spec/activitypub/#Question - Add tests for the ActivityPub implementation and the Api controller - The api had to be shifted a bit -> the `serialize...` functions in the base api take only the entity classes now instead of their dto variant -> touched a lot of api classes because of this

- fix the end date being ignored upon poll creation - make the poll end date DATETIMETZ_IMMUTABLE -> with time zone - implement refreshing the vote counts of remote polls - fix handling of `Update` activities -> only edit the poll (and discarding all votes) when the content actually changed, pass through the correct object to refresh the poll counts - send an `Update` activity when a vote is created on a local poll - fix missing query from `EntryCommentRepository` and `PostCommentRepository` in the `PollVoteFactory` - add a way to invalidate the cache of an activity object - add support for the `closed` property on polls (it is the same as `endTime`) - add a way to just show the results of a poll in the UI

- if an object contains a poll, it needs to be of type 'Question' in the AP representation - update the testing snapshots - scrub the URL from `Question` object snapshots as well

BentiGorlich · 2026-09-21T10:56:57Z

As I implemented all the remaining things a while back and now tested it on my server in combination with mastodon, I think this is ready

- fix duplicate choices not being noticed - fix endDate not being assigned in the EntryFactory - fix choices not being part of the poll after being created - add tests for that

# Conflicts: # translations/messages.en.yaml

melroy89 · 2026-09-22T13:13:13Z

Just some small minor remarks;

The refresh() workaround adds a DB round-trip and only populates choices lazily while the EM is open; directly appending to the collection would be more robust (note line 80 already uses $poll->choices[] in createPoll).
tests/Unit/Service/PollManagerTest.php boots the kernel/DB, it's a functional test under Unit/...

- append the choice array of the poll, rather than refreshing the entity - move the test to the functional directory

blued-gear · 2026-09-22T23:11:55Z

@@ -0,0 +1,24 @@
+.poll {
+  margin: auto;


Why centered instead of left-aligned?

blued-gear · 2026-09-22T23:20:40Z

@@ -0,0 +1,33 @@
+<?php


This looks like dev code which should not be in prod.

blued-gear · 2026-09-23T15:54:03Z

        // Rate limiting already taken care of
        $comment = $manager->create($dto, $this->getUserOrThrow(), rateLimit: false);
-        $dto = $factory->createDto($comment);
        $dto->parent = $parent;


Whats up with this line? You removed the creation of the dto variable, but still use it here.

blued-gear · 2026-09-23T15:54:11Z

        // Rate limiting already taken care of
        $comment = $manager->create($dto, $this->getUserOrThrow(), rateLimit: false);
-        $dto = $factory->createDto($comment);
        $dto->parent = $parent;


blued-gear · 2026-09-23T15:58:22Z

+    )]
+    #[OA\Response(
+        response: 400,
+        description: 'Poll was not valid. Possibly: poll already ended, choices do not exist, user already voted',


user already voted

maybe return an HTTP "conflict" status instead of "bad request"

blued-gear · 2026-09-23T19:21:08Z

+
+        $voteEntities = [];
+        foreach (array_unique($choices) as $choice) {
+            $choiceEntity = $poll->findChoice($choice);


This does not check if the choice is a valid one. As this function can be called with AP originating user content, it must be checked.

I suggest the check should throw an exception on invalid input. Then the check in the Controllers can be replaced with a try-catch which rethrow as a fitting Http-Exception.

blued-gear · 2026-09-23T19:23:39Z

+
+    public function getContentOfPoll(Poll $poll): Entry|EntryComment|Post|PostComment|null
+    {
+        return $this->entryRepository->findOneBy(['poll' => $poll])


why not poll->getSubject()?

blued-gear · 2026-09-23T19:26:39Z

+    }
+
+    /**
+     * Call PollManager::canCreateFromApObject() first, this that $object contains all the necessary information.


this <-> that

blued-gear · 2026-09-23T19:31:31Z

+    }
+
+    /**
+     * Call PollManager::canCreateFromApObject() first, this that $payload contains all the necessary information.


this <-> that

Call PollManager::canCreateFromApObject() first, to ensure that $payload contains all the necessary information.

blued-gear · 2026-09-23T19:44:32Z

+        self::assertNotNull($entry->poll->findChoice('C'));
+        self::assertEquals(1, $entry->poll->findChoice('C')->voteCount);
+    }
+


Some negative tests would be nice. Like activities with invalid choices, multiple votes for the same choice by the same user.

blued-gear · 2026-09-23T19:54:20Z

Is it planned that incoming votes to local polls will be federated out via Announces?

melroy89 · 2026-09-23T19:58:33Z

+poll_vote:
+  controller: App\Controller\PollVoteController::vote
+  path: /poll/{id}/vote
+  methods: [GET]


Because voting is a one-time state change, exposing it as GET lets another site make a logged-in user vote by sending them to a crafted link. Please switch this route and the poll form to POST and validate a CSRF token.

BentiGorlich self-assigned this Apr 23, 2026

BentiGorlich added enhancement New feature or request frontend Visual issues, improvements, bugs or other aspects relating mostly to the front end activitypub ActivityPub related issues backend Backend related issues and pull requests api API related issues and pull requests labels Apr 23, 2026

BentiGorlich force-pushed the new/polls branch 2 times, most recently from ca5a66c to 21b69c7 Compare May 5, 2026 14:17

BentiGorlich force-pushed the new/polls branch from 21b69c7 to 1357bac Compare July 11, 2026 10:47

BentiGorlich force-pushed the new/polls branch from 1357bac to d363e4b Compare July 29, 2026 17:42

BentiGorlich added 5 commits September 21, 2026 11:30

Fix tests

803545b

Fix merge errors

29d6baf

Make posts and comments with a poll being AP type 'Question'

d227f4e

- if an object contains a poll, it needs to be of type 'Question' in the AP representation - update the testing snapshots - scrub the URL from `Question` object snapshots as well

BentiGorlich force-pushed the new/polls branch from 94fdbef to d227f4e Compare September 21, 2026 10:45

BentiGorlich marked this pull request as ready for review September 21, 2026 10:56

melroy89 requested review from blued-gear and melroy89 September 21, 2026 13:22

melroy89 reviewed Sep 21, 2026

View reviewed changes

Comment thread src/Factory/EntryFactory.php

melroy89 reviewed Sep 21, 2026

View reviewed changes

Comment thread src/Service/PollManager.php

BentiGorlich added 2 commits September 22, 2026 00:23

Fix dups, missing endDate, empty poll

8347286

- fix duplicate choices not being noticed - fix endDate not being assigned in the EntryFactory - fix choices not being part of the poll after being created - add tests for that

Merge branch 'main' into new/polls

35575ab

# Conflicts: # translations/messages.en.yaml

BentiGorlich requested a review from melroy89 September 22, 2026 08:02

Move test class, append array with choice

bd4b4e3

- append the choice array of the poll, rather than refreshing the entity - move the test to the functional directory

blued-gear reviewed Sep 23, 2026

View reviewed changes

melroy89 reviewed Sep 23, 2026

View reviewed changes

Conversation

BentiGorlich commented Apr 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BentiGorlich commented Apr 23, 2026

Uh oh!

BentiGorlich commented Sep 21, 2026

Uh oh!

Uh oh!

Uh oh!

melroy89 commented Sep 22, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

blued-gear commented Sep 23, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

BentiGorlich commented Apr 23, 2026 •

edited

Loading