Copilot/rewrite backup device opening again#133
Open
MaxG87 wants to merge 4 commits into
Open
Conversation
- Add `OpenDirectory: Path | None = None` to `Configuration` with tilde expansion. When set, devices are mounted in named subdirectories under this path for both the `open` and `backup` commands. - Remove the `dest` positional CLI argument from the `open` command. Users should use `OpenDirectory` in the config instead. - Fix the TOML parser to extract all top-level fields (previously fields like `SudoPassCmd` were silently dropped in TOML configs). - Use `mkdir(parents=True, exist_ok=True)` in `_open_device` so the full path including `OpenDirectory` is created as needed. - Update `backup` command to use `OpenDirectory / cfg.Name` as mount destination when configured; temp dir (cleaned up afterwards) otherwise. - Update tests and example configs to reflect the new behaviour.
MaxG87
force-pushed
the
copilot/rewrite-backup-device-opening-again
branch
from
2bb537b to
57e86ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.