Repository navigation
release: v7.0.7 - #75
Conversation
- fix(ui): measure real row heights so the transcript reaches the bottom
There was a problem hiding this comment.
🧪 PR Review is completed: Version bump to 7.0.7 is correct, but package-lock.json is left at 7.0.6 — the release workflow installs with npm ci, which fails on an out-of-sync lockfile, so sync it before merging. Also note there is no CHANGELOG.md entry for 7.0.7 yet (the changelog documents every release, including pure version bumps like 6.9.3).
Skipped files
CHANGELOG.md: Skipped file patternpackage-lock.json: Skipped file pattern
⬇️ Low Priority Suggestions (1)
package.json (1 suggestion)
Location:
package.json(Lines 3-3)🟠 Release Pipeline
Issue:
package.jsonis bumped to7.0.7, butpackage-lock.jsonstill carries the rootversion7.0.6(lines 3 and 9). The release workflow installs withnpm ci, which errors out whenpackage.jsonand the lockfile are out of sync ("Missing: @matterailab/orbcode@7.0.7 from lock file"), so the automated publish fails at the Install step. The documented release process (npm version, RELEASE.md) updates both files together for exactly this reason.Fix: Sync the lockfile root version: run
npm install --package-lock-only, or change the two rootversionfields inpackage-lock.json(lines 3 and 9) from7.0.6to7.0.7, and commit the lockfile to this release PR. Leave thecross-spawn@7.0.6dependency entry (line 2118) untouched.Impact: Prevents the release workflow from failing at
npm ciand keeps the lockfile consistent with the version being published.- "version": "7.0.7", +
Follow-up to v7.0.6: the transcript tail (task list, completion box, last diff lines) could still hide under the composer on Windows, worse in larger windows.
Scroll placement and virtualization relied only on estimated wrapped heights. Mounted rows and the live section now report their real Yoga height via
onSizeChange, and those replace the estimates; estimates only cover never-mounted rows.The fix commit (99d1499) was pushed to
maindirectly by mistake; this PR carries the version bump and moves its changelog entry from 7.0.6 to 7.0.7.npm run test:ui45/45 pass