Skip to content

<fix>[vm]: add conditional stop target precheck - #4673

Open
zstack-robot-2 wants to merge 1 commit into
feature-5.5.38-ha-rescheckfrom
sync/haoyu.ding/fix-87164@@3
Open

<fix>[vm]: add conditional stop target precheck#4673
zstack-robot-2 wants to merge 1 commit into
feature-5.5.38-ha-rescheckfrom
sync/haoyu.ding/fix-87164@@3

Conversation

@zstack-robot-2

Copy link
Copy Markdown
Collaborator

Route network-group stop requests through the VM actor.
Reuse allocator dry-run before the existing cold Stop flow.

Resolves: ZSTAC-87164
Test: HaNetworkGroupCoreFlowCase

Change-Id: I5b480ff0b8c643782c80136691e73223d8cf45c6

sync from gitlab !10668

Keep ordinary StopVmInstanceMsg and its extension behavior unchanged.
Expose the full candidate-host overload for premium actor reuse.
Keep explicit HA allocation purposes.
Classify conditional-stop failures with global HA error codes.

Resolves: ZSTAC-87164

Test: HaNetworkGroupCoreFlowCase
Test: HaNoneEnableHaPrecheckCase
Test: FaultTolerancePrimaryStillRunningCase

Change-Id: I5b480ff0b8c643782c80136691e73223d8cf45c6
@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 44 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: http://open.zstack.ai:20001/code-reviews/zstack-cloud.yaml (via .coderabbit.yaml)

Review profile: CHILL

Plan: Pro

Run ID: b8af6e67-efb3-4340-a540-0cbf63c3a55f

📥 Commits

Reviewing files that changed from the base of the PR and between a1ef8af and 04ffc8f.

⛔ Files ignored due to path filters (2)
  • conf/i18n/globalErrorCodeMapping/global-error-en_US.json is excluded by !**/*.json
  • conf/i18n/globalErrorCodeMapping/global-error-zh_CN.json is excluded by !**/*.json
📒 Files selected for processing (3)
  • compute/src/main/java/org/zstack/compute/vm/VmInstanceBase.java
  • header/src/main/java/org/zstack/header/allocator/HostAllocationPurpose.java
  • utils/src/main/java/org/zstack/utils/clouderrorcode/CloudOperationsErrorCode.java

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants