Skip to content

<fix>[storage]: repair 4.4.52-sm baseline failures - #4670

Open
ZStack-Robot wants to merge 1 commit into
4.4.52-smfrom
sync/jin.ma/fix/ZSTAC-87030@@2
Open

<fix>[storage]: repair 4.4.52-sm baseline failures#4670
ZStack-Robot wants to merge 1 commit into
4.4.52-smfrom
sync/jin.ma/fix/ZSTAC-87030@@2

Conversation

@ZStack-Robot

Copy link
Copy Markdown
Collaborator

Summary

  • Guard image snapshot loading when an unattached volume has no VM UUID.
  • Serialize backup storage reconnect accounting and cancel reconnect promptly at the threshold.
  • Fix the core-local VmPmuConfigCase helper argument shadowing.

Cross-repository CI

Verification

  • VmPmuConfigCase stability: PASS.
  • BinBuild and UTBuild: PASS in the previous unpaired round.
  • BackupStorage reconnect and image snapshot failures are covered by the external UnitTest run.
  • The previous UnitTest red cases were Premium baseline failures plus the intentional core_MustFailCase; none maps to this MR's three diffs.
  • New paired @@2 CI: pending.

Related: ZSTAC-87030 / premium!15062

sync from gitlab !10723

Handle snapshots from unattached volumes before copying VM security
level. Avoid Groovy closure self-assignment in the PMU Case. Stop backup
storage reconnect timers as soon as the configured attempt limit is
reached and serialize their lifecycle.

Tests: CreateVmFromVolumeSnapshotCase
Tests: VmPmuConfigCase
Tests: BackupStorageAutoConnectCase

Related: ZSTAC-87030 / premium!14908
Resolves: ZCF-0

Change-Id: I91ff6204062811ec6bce1fce6ec313ee72c83032
@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 44 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 51a081e9-3b5c-453e-b83d-081b8edc7531

📥 Commits

Reviewing files that changed from the base of the PR and between d4f17df and 76be837.

📒 Files selected for processing (3)
  • image/src/main/java/org/zstack/image/ImageManagerImpl.java
  • storage/src/main/java/org/zstack/storage/backup/BackupStoragePingTracker.java
  • test/src/test/groovy/org/zstack/test/integration/kvm/vm/VmPmuConfigCase.groovy

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants