Skip to content

<fix>[localstorage]: guard local storage writes by initialized file - #4664

Open
MatheMatrix wants to merge 2 commits into
zsv_5.1.0from
sync/tao.gan/ZSV-12865@@3
Open

<fix>[localstorage]: guard local storage writes by initialized file#4664
MatheMatrix wants to merge 2 commits into
zsv_5.1.0from
sync/tao.gan/ZSV-12865@@3

Conversation

@MatheMatrix

Copy link
Copy Markdown
Owner

Local storage create and download flows could write into the host root
filesystem when the mount directory existed but the real storage
filesystem was not mounted after boot.

Pass the initialized marker path to normal localstorage agent commands
and manual SFTP download commands. Also write graphical block-device
fstab entries with nofail and a bounded systemd device timeout.

Existing callers remain compatible because the agent guard only runs
when initializedFilePath is sent.

Resolves: ZSV-12865

Change-Id: I7567666471646a7776766763616d626b66677965

sync from gitlab !10676

Resolves: ZSV-12865

Change-Id: I6b696b62746e797a727969686675696365676373
Resolves: ZSV-12865

Change-Id: I7372756b667a6c626368676f7579736c77777665
@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 39 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: f4a4414c-af0d-4165-9fff-a8a006dbb02d

📥 Commits

Reviewing files that changed from the base of the PR and between 9f0b59d and 8f4a2a3.

📒 Files selected for processing (2)
  • compute/src/main/java/org/zstack/compute/host/MountBlockDeviceHelper.java
  • plugin/localstorage/src/main/java/org/zstack/storage/primary/local/LocalStorageKvmSftpBackupStorageMediatorImpl.java

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants