Skip to content

<fix>[network]: skip non kvm vxlan attach#4121

Merged
MatheMatrix merged 1 commit into
5.5.22from
sync/yingzhe.hu/fix/dpu-vxlan-hotplug-skip-kvm-realize-5.5.22
May 28, 2026
Merged

<fix>[network]: skip non kvm vxlan attach#4121
MatheMatrix merged 1 commit into
5.5.22from
sync/yingzhe.hu/fix/dpu-vxlan-hotplug-skip-kvm-realize-5.5.22

Conversation

@MatheMatrix
Copy link
Copy Markdown
Owner

Summary

Fix DPU baremetal VXLAN NIC hotplug failure caused by the KVM VXLAN attach-resource extension sending KVM agent messages to a non-KVM host.

Changes

  • Skip KVMRealizeL2VxlanNetworkBackend.instantiateResourceOnAttachingNic() when the target host hypervisor is not KVM.
  • Keep existing KVM VXLAN realization behavior unchanged for KVM hosts.

Testing

  • mvn -pl plugin/vxlan -DskipTests compile

Related DPU agent MR: http://dev.zstack.io:9080/zstackio/zstack-bm2-dpu-agent/-/merge_requests/9

Resolves: ZCF-0

sync from gitlab !10020

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 27, 2026

Warning

Review limit reached

@MatheMatrix, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 42 minutes and 27 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: http://open.zstack.ai:20001/code-reviews/zstack-cloud.yaml (via .coderabbit.yaml)

Review profile: CHILL

Plan: Pro

Run ID: 5362e693-a463-46da-8562-ceadef09f715

📥 Commits

Reviewing files that changed from the base of the PR and between a621cf2 and 57876c9.

📒 Files selected for processing (1)
  • plugin/vxlan/src/main/java/org/zstack/network/l2/vxlan/vxlanNetworkPool/KVMRealizeL2VxlanNetworkBackend.java
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch sync/yingzhe.hu/fix/dpu-vxlan-hotplug-skip-kvm-realize-5.5.22

Comment @coderabbitai help to get the list of available commands and usage tips.

@MatheMatrix MatheMatrix force-pushed the sync/yingzhe.hu/fix/dpu-vxlan-hotplug-skip-kvm-realize-5.5.22 branch 7 times, most recently from 3f51a61 to ddcfacc Compare May 27, 2026 11:02
Skip KVM VXLAN realization when attaching NICs to hosts whose hypervisor type is not KVM.

Resolves: ZSTAC-85081

Change-Id: I339d08ccba1a302353b316b40ec471ae37274cc7
@MatheMatrix MatheMatrix force-pushed the sync/yingzhe.hu/fix/dpu-vxlan-hotplug-skip-kvm-realize-5.5.22 branch from ddcfacc to 57876c9 Compare May 28, 2026 02:51
@MatheMatrix MatheMatrix merged commit 113a77a into 5.5.22 May 28, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants