Skip to content

DialogHost: don't wait 300 ms to focus when transitions are disabled, and keep focus already inside the dialog - #4098

Merged
Keboo merged 1 commit into
MaterialDesignInXAML:masterfrom
BrensNina:fix/dialoghost-focus-without-transitions
Sep 28, 2026
Merged

Keboo merged 1 commit into
MaterialDesignInXAML:masterfrom
BrensNina:fix/dialoghost-focus-without-transitions

Conversation

@BrensNina

Copy link
Copy Markdown
Contributor

Fixes #4097

  • With TransitionAssist.DisableTransitions, the focus step on open runs right away instead of after 300 ms. With transitions, the delay (Somtimes dialoghost doesn't have focus. #2912) is kept.
  • That step no longer moves the focus if it is already inside the dialog (e.g. the user clicked a field). DialogSession.UpdateContent is unchanged.
  • UI tests for both, with both DialogHost styles; they fail on master.

@Keboo Keboo added this to the 5.4.0 milestone Sep 28, 2026
@Keboo

Keboo commented Sep 28, 2026

Copy link
Copy Markdown
Member

Thank you for this PR.

@Keboo
Keboo enabled auto-merge (squash) September 28, 2026 01:25
@Keboo
Keboo merged commit 3758396 into MaterialDesignInXAML:master Sep 28, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DialogHost with DisableTransitions: focus moves into the dialog only after 300 ms, overriding what the user did meanwhile

2 participants