Repository navigation
docs(rules): one Copilot review per PR, another only while high findings remain - #12250
Merged
Merged
Conversation
…igh finding "Stop once a round yields no new inline comments" let every round with findings draw the next one; #12239, a docs PR, collected three. The owner's rule of 2026-10-23: a second round only when the first found something big and its fix was pushed, never a third; small and medium findings get their fixes and resolved threads with no new round, because each round re-reads the whole diff and costs premium requests. CLAUDE.md, the open-pr skill and /pull_request say the same. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0175hA62juZoajMcqKxWFGza
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0175hA62juZoajMcqKxWFGza
…gh findings The owner's refinement of the same morning: not "never a third", but "only as long as there are high or critical findings; otherwise fix and done". Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0175hA62juZoajMcqKxWFGza
MarkusNeusinger
changed the title
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Resolve the contradictory review-round guidance in .claude/skills/open-pr/SKILL.md.
1 open issue
What changed in this PR
This pull request updates repository guidance to limit Copilot reviews to one per PR, allowing a second review only after fixing a high-severity finding and prohibiting a third review.
Changes:
- Replaces the broader substantive-rework exception with a high-severity-only exception.
- Synchronizes
CLAUDE.md,/pull_request, and theopen-prskill. - Adds a changelog entry documenting the policy.
| File | Summary |
|---|---|
CLAUDE.md |
Defines the revised Copilot review-request limit. |
changelog.d/copilot-one-round.md |
Records the review-policy change. |
agentic/commands/pull_request.md |
Updates the PR workflow’s review guidance. |
.claude/skills/open-pr/SKILL.md |
Applies the new policy, but retains contradictory guidance permitting additional substantive review rounds; this has an unresolved moderate finding with 3 votes. |
Review effort: Lite
…und rule The Gotchas paragraph still allowed "a couple of rounds" after a substantive re-request, and watch-copilot.sh described count 2 as the extra round after fixes. Found by the Gemini Flash and Copilot reviews of #12250. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0175hA62juZoajMcqKxWFGza
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
open-prskill and/pull_requeststep 8 now carry the owner's rule of 2026-10-23: Copilot reviews a PR once; another round only while the previous round found something high or critical (a real bug, a security or correctness issue, a wrong mechanism) whose fix was pushed; a round with only low and medium findings gets its fixes pushed and its threads resolved, and that is the end..github/copilot-instructions.mddoes not carry this rule, so it is unchanged.Plan
N/A
Test plan
uv run python -m tools.changelog check --base origin/mainpasses.