Repository navigation
docs: mirror proper-lint-fixes rule into Copilot instructions - #12190
Merged
Merged
Conversation
Owner decision 2026-10-15: the CLAUDE.md rule against disable comments (eslint-disable, noqa and similar without explicit approval) applies to Copilot too. It sits on the "Fixing linting/formatting issues" task line, where Copilot meets lint work, and tests/unit/test_agent_instructions.py pins it as a mirrored rule (prohibition and approval exit, not the topic). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GdMSqLR5ww4ji74EUSmk9M
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GdMSqLR5ww4ji74EUSmk9M
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The narrowly scoped instruction, test, and changelog changes are consistent, with no unresolved findings.
0 open findings
What changed in this PR
Mirrors the existing lint-fix guidance into Copilot instructions without expanding the scope to other rules.
Changes:
- Requires fixing lint causes rather than adding suppression comments without owner approval.
- Adds shared-rule assertions covering the prohibition and approval exception.
- Records the update in a changelog fragment.
| File | Description |
|---|---|
| tests/unit/test_agent_instructions.py | Pins the shared lint-fix rule and approval exception. |
| changelog.d/copilot-proper-lint-fixes.md | Documents the guidance update. |
| .github/copilot-instructions.md | Mirrors the existing proper-lint-fixes rule. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CLAUDE.mdrule "Proper lint fixes only" now also appears in.github/copilot-instructions.md, on the "Fixing linting/formatting issues" task line. It says to fix the cause, and never to add disable comments (eslint-disable,noqa,type: ignore, or similar) unless the repository owner explicitly approves.tests/unit/test_agent_instructions.pypins the rule as mirrored. The checked phrases cover the prohibition and the approval exception, not just the topic.CLAUDE.md-only rule is mirrored, per the same decision.Plan
N/A
Test plan
uv run pytest tests/unit/test_agent_instructions.py(35 passed)uv run ruff checkanduv run ruff format --checkon the test fileuv run python -m tools.changelog check --base origin/main