Repository navigation
docs: align Copilot instructions with CLAUDE.md - #12188
Merged
Merged
Conversation
Owner decisions 2026-10-15: - The "fix small build/test blockers directly, even when out of scope" rule applies to every agent. copilot-instructions.md gains it under Important Rules (with the ~20-line bar and ask-first above it), and its Common Issues line no longer tells Copilot to leave pre-existing failures alone. - Python tooling is uv only: the pip fallback is gone from both Copilot lines, and CLAUDE.md states the rule explicitly. Also fixes one clear contradiction found while comparing the two guides: Task Suitability listed "adding new plot types following existing patterns" as a Copilot task, which the mandatory pipeline forbids; it now points at a spec-request issue. Both rules are pinned as mirrored in tests/unit/test_agent_instructions.py. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GdMSqLR5ww4ji74EUSmk9M
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GdMSqLR5ww4ji74EUSmk9M
Owner
Author
|
Remaining differences between
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused guidance updates and matching test assertions have no unresolved blocking issues.
0 open findings
What changed in this PR
Aligns Copilot guidance with CLAUDE.md and adds tests to prevent shared rules from drifting.
Changes:
- Aligns small-blocker fixes and
uv-only Python tooling guidance. - Routes new plot proposals through
spec-requestissues. - Adds mirrored-rule assertions and a changelog fragment.
| File | Description |
|---|---|
| tests/unit/test_agent_instructions.py | Pins both shared rules. |
| CLAUDE.md | Makes uv-only tooling explicit. |
| changelog.d/align-copilot-instructions.md | Records the guidance alignment. |
| .github/copilot-instructions.md | Resolves conflicting repair, tooling, and plot-proposal guidance. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/copilot-instructions.mdgets it under Important Rules, with the under-~20-lines bar and ask-first above it. Its Common Issues line used to tell Copilot to test only its own changes and leave pre-existing failures alone; it now points at the rule.uvonly. The twopipfallbacks in the Copilot guide are gone, and CLAUDE.md "Package Management" says so explicitly so the rule is mirrored.spec-requestissue.tests/unit/test_agent_instructions.pypins both rules as mirrored. The keywords carry the obligation and its limit, not only the subject.Other differences between the two guides are listed in the PR conversation, not fixed here; they are omissions or owner calls rather than contradictions.
Plan
N/A
Test plan
uv run pytest tests/unit/test_agent_instructions.py(34 passed)uv run ruff checkanduv run ruff format --checkon the test fileuv run python -m tools.changelog check --base origin/main