Skip to content

Add pagination to Admin Users table for performance#7997

Open
donny-wong wants to merge 5 commits into
MarkUsProject:masterfrom
donny-wong:admin_user_list_pagination
Open

Add pagination to Admin Users table for performance#7997
donny-wong wants to merge 5 commits into
MarkUsProject:masterfrom
donny-wong:admin_user_list_pagination

Conversation

@donny-wong

@donny-wong donny-wong commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Proposed Changes

(Describe your changes here. Also describe the motivation for your changes: what problem do they solve, or how do they improve the application or codebase? If this pull request fixes an open issue, use a keyword to link this pull request to the issue.)

Replaced the full-table client-side load with server-side pagination locked to 100 records per page. This resolves severe rendering lags and heavy query payloads by fetching rows in explicit, manageable windows.

Screenshots of your changes (if applicable)
Associated documentation repository pull request (if applicable)

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change that adds functionality) x
🐛 Bug fix (non-breaking change that fixes an issue)
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.
  • I have updated the project documentation, if applicable.
    • This is required for new features.
  • If this is my first contribution, I have added myself to the list of contributors.

After opening your pull request:

  • I have updated the project Changelog (this is required for all changes).
  • I have verified that the pre-commit.ci checks have passed.
  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported by Coveralls.
  • I have requested a review from a project maintainer.

Questions and Comments

(Include any questions or comments you have regarding your changes.)

@coveralls

coveralls commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 27252220931

Coverage decreased (-0.01%) to 90.293%

Details

  • Coverage decreased (-0.01%) from the base build.
  • Patch coverage: 7 uncovered changes across 2 files (62 of 69 lines covered, 89.86%).
  • No coverage regressions found.

Uncovered Changes

File Changed Covered %
app/javascript/Components/admin_users_list.jsx 20 16 80.0%
app/controllers/admin/users_controller.rb 27 24 88.89%
Total (3 files) 69 62 89.86%

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 50238
Covered Lines: 46334
Line Coverage: 92.23%
Relevant Branches: 2259
Covered Branches: 1067
Branch Coverage: 47.23%
Branches in Coverage %: Yes
Coverage Strength: 126.49 hits per line

💛 - Coveralls

@donny-wong donny-wong requested a review from Naragod June 10, 2026 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants