Skip to content

Consolidate release url extraction - #1670

Merged
cyanzhong merged 1 commit into
mainfrom
develop
Aug 8, 2026
Merged

Consolidate release url extraction#1670
cyanzhong merged 1 commit into
mainfrom
develop

Conversation

@cyanzhong

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates ExtensionRelease.pageURL extraction to handle raw.githubusercontent.com/.../refs/tags/... URL shapes, and extends unit coverage to ensure both “official” and non-official repositories produce the expected GitHub page URLs.

Changes:

  • Extend ExtensionRelease.pageURL parsing to treat raw.githubusercontent.com/{owner}/{repo}/refs/tags/{tag}/... as {ref} = {tag}.
  • Add new unit tests for raw tag-ref URLs for both generic and MarkEdit-app repositories.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
MarkEditMac/Modules/Tests/ExtensionCoreTests.swift Adds test coverage for raw.githubusercontent.com/.../refs/tags/... page URL derivation, including official repo behavior.
MarkEditMac/Modules/Sources/ExtensionCore/ExtensionRegistry.swift Updates pageURL extraction to correctly pull the tag name from refs/tags raw URLs.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@cyanzhong
cyanzhong merged commit 94a049b into main Aug 8, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants