Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts concurrency annotations across the app to better align with Swift strict concurrency checks, primarily by tightening actor isolation for UI-facing APIs and marking cross-boundary interfaces as sendable.
Changes:
- Annotates several UI-related entry points/types with
@MainActor. - Marks the updater XPC interface protocol as
Sendable. - Tweaks a WebKit delegate callback signature for stricter main-actor handling.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| UpdateInstaller/UpdateInstalling.swift | Marks the XPC protocol as Sendable to satisfy stricter concurrency requirements. |
| QuickLookMac/QuickLookViewController.swift | Adjusts navigation delegate callback closure to be @MainActor. |
| MarkEditMac/Sources/Updater/AppUpdater.swift | Moves update-check entry point onto @MainActor. |
| MarkEditMac/Sources/Main/AppWritingTools.swift | Makes Writing Tools helper API @MainActor for UI safety. |
| MarkEditMac/Sources/Extras/NSMenu+Extras.swift | Restricts menu hack state and swizzled method to the main actor. |
| MarkEditMac/Sources/Editor/Views/EditorStatusView.swift | Main-actor isolates a UI label-view protocol requirement. |
| MarkEditMac/Modules/Sources/FileVersion/FileVersionPicker.swift | Main-actor isolates the version picker delegate protocol. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.