Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens the in-app updater’s staging workflow by preventing multiple concurrent attempts to stage an update, closing a timing window where staging could be started more than once.
Changes:
- Introduces a
reserveStaging()helper to atomically “claim” staging before launching async work. - Updates automatic and manual update flows to reserve staging up-front before spawning
Tasks. - Centralizes staging release (
isStaging = false) viadeferinsidestageUpdate.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| MarkEditMac/Sources/Updater/AppUpdater+Install.swift | Adds reserveStaging() and adjusts staging lifecycle handling during stageUpdate. |
| MarkEditMac/Sources/Updater/AppUpdater.swift | Uses reserveStaging() in update entry points to prevent concurrent staging tasks. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.