Fix popover padding #2900
Merged
Merged
Conversation
Popover styles regressed after upgrading to bootstrap v5.3. Add .popover class to popovers so that bootstrap's css variables for popovers apply to generated site, as Bootstrap now scopes popover variables to tags with the .popover class explicitly set.
Contributor
Author
|
Happy holidays btw heehee |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2900 +/- ##
=======================================
Coverage 71.32% 71.32%
=======================================
Files 133 133
Lines 7232 7232
Branches 1714 1705 -9
=======================================
Hits 5158 5158
Misses 1973 1973
Partials 101 101 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Thanks for tackling this, @Harjun751 👍 |
gerteck
approved these changes
May 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What is the purpose of this pull request?
Resolves #2896
Overview of changes:
Fixes missing popover padding
Anything you'd like to highlight/discuss:
This issue resulted from the Bootstrap v5.3 upgrade. It seems that Bootstrap extracted some values into scoped variables - for the popover, they'd only apply on elements with the
.popoverclass. So adding this class to the popover element fixes the problem.There were some slight issues with the dark theme style, like this white padding here:

So I just overrid some of the styles. Let me know if this looks okay.
Testing instructions:
Proposed commit message: (wrap lines at 72 characters)
Fix popover padding
Checklist: ☑️
Reviewer checklist:
Indicate the SEMVER impact of the PR:
At the end of the review, please label the PR with the appropriate label:
r.Major,r.Minor,r.Patch.Breaking change release note preparation (if applicable):