Skip to content

Fix popover padding #2900

Merged
Harjun751 merged 3 commits into
MarkBind:masterfrom
Harjun751:fix-popover-padding
May 31, 2026
Merged

Fix popover padding #2900
Harjun751 merged 3 commits into
MarkBind:masterfrom
Harjun751:fix-popover-padding

Conversation

@Harjun751
Copy link
Copy Markdown
Contributor

@Harjun751 Harjun751 commented May 30, 2026

What is the purpose of this pull request?

  • Documentation update
  • Bug fix
  • Feature addition or enhancement
  • Code maintenance
  • DevOps
  • Improve developer experience
  • Others, please explain:

Resolves #2896

Overview of changes:
Fixes missing popover padding

Anything you'd like to highlight/discuss:
This issue resulted from the Bootstrap v5.3 upgrade. It seems that Bootstrap extracted some values into scoped variables - for the popover, they'd only apply on elements with the .popover class. So adding this class to the popover element fixes the problem.

There were some slight issues with the dark theme style, like this white padding here:
image
So I just overrid some of the styles. Let me know if this looks okay.

Testing instructions:

Proposed commit message: (wrap lines at 72 characters)

Fix popover padding


Checklist: ☑️

  • Updated the documentation for feature additions and enhancements
  • Added tests for bug fixes or features
  • Linked all related issues
  • No unrelated changes

Reviewer checklist:

Indicate the SEMVER impact of the PR:

  • Major (when you make incompatible API changes)
  • Minor (when you add functionality in a backward compatible manner)
  • Patch (when you make backward compatible bug fixes)

At the end of the review, please label the PR with the appropriate label: r.Major, r.Minor, r.Patch.

Breaking change release note preparation (if applicable):

  • To be included in the release note for any feature that is made obsolete/breaking

Give a brief explanation note about:

  • what was the old feature that was made obsolete
  • any replacement feature (if any), and
  • how the author should modify his website to migrate from the old feature to the replacement feature (if possible).

Harjun751 added 2 commits May 30, 2026 21:06
Popover styles regressed after upgrading
to bootstrap v5.3.

Add .popover class to popovers so that
bootstrap's css variables for popovers
apply to generated site, as
Bootstrap now scopes popover variables
to tags with the .popover class explicitly
set.
@Harjun751 Harjun751 requested a review from a team May 30, 2026 13:26
@Harjun751
Copy link
Copy Markdown
Contributor Author

Happy holidays btw heehee

@codecov
Copy link
Copy Markdown

codecov Bot commented May 30, 2026

Codecov Report

❌ Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 71.32%. Comparing base (79c1860) to head (fc1ec1c).

Files with missing lines Patch % Lines
packages/vue-components/src/Popover.vue 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2900   +/-   ##
=======================================
  Coverage   71.32%   71.32%           
=======================================
  Files         133      133           
  Lines        7232     7232           
  Branches     1714     1705    -9     
=======================================
  Hits         5158     5158           
  Misses       1973     1973           
  Partials      101      101           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@damithc
Copy link
Copy Markdown
Contributor

damithc commented May 30, 2026

Thanks for tackling this, @Harjun751 👍

Copy link
Copy Markdown
Member

@gerteck gerteck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice touch for the dark mode! Nice and clean solution ~

image

happy holidays!

@Harjun751 Harjun751 merged commit 098614b into MarkBind:master May 31, 2026
11 checks passed
@github-actions github-actions Bot added the r.Patch Version resolver: increment by 0.0.1 label May 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

r.Patch Version resolver: increment by 0.0.1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add padding to popover

3 participants