MDEV-40608 MariaDB-devel is incomplete for plugins - #5486
Conversation
create and install mariadb-plugin-config.cmake
|
|
|
@vaintroub FYI, it's a draft, I'm not proposing it for a merge yet. But see the direction. |
There was a problem hiding this comment.
Pull request overview
Adds an installable CMake config intended to make the MariaDB development package usable for building plugins, and refactors plugin CMake plumbing to support that packaging.
Changes:
- Introduces
support-files/mariadb-plugin-config.cmake.inand installs the configured result into${INSTALL_SHAREDIR}/cmake/mariadb-plugin/. - Refactors plugin discovery to live in the top-level
CMakeLists.txtand introducesVERIFY_PLUGINS()incmake/plugin.cmake. - Renames the primary plugin macro to
MARIADB_ADD_PLUGINwhile keepingMYSQL_ADD_PLUGINas a compatibility wrapper.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| support-files/mariadb-plugin-config.cmake.in | New installed CMake config template intended for plugin consumers. |
| support-files/CMakeLists.txt | Generates/installs the new plugin config CMake file. |
| CMakeLists.txt | Moves plugin subdirectory enumeration into the top-level build and calls VERIFY_PLUGINS(). |
| cmake/plugin.cmake | Introduces MARIADB_ADD_PLUGIN, keeps MYSQL_ADD_PLUGIN wrapper, and adds VERIFY_PLUGINS(). |
| .gitignore | Ignores the generated support-files/mariadb-plugin-config.cmake. |
| MACRO(DTRACE_INSTRUMENT) | ||
| ENDMACRO() | ||
| MACRO(ADD_VERSION_INFO) | ||
| ENDMACRO() | ||
| MACRO(MYSQL_INSTALL_TARGETS) | ||
| INSTALL(TARGETS ${ARGV}) | ||
| ENDMACRO() | ||
| ADD_CUSTOM_TARGET(GenError) |
There was a problem hiding this comment.
not so easy. I need to try it on a plugin with tests
you mean "find_package(mariadb-plugin CONFIG REQUIRED)" . Yes, I thought about something like that |
create and install mariadb-plugin-config.cmake