Fix galera SST-abort tests to allow exit code 0 on some platforms - #5485
Open
hemantdangi-gc wants to merge 1 commit into
Open
Fix galera SST-abort tests to allow exit code 0 on some platforms#5485hemantdangi-gc wants to merge 1 commit into
hemantdangi-gc wants to merge 1 commit into
Conversation
Issue: galera_sst_mariabackup_missing_ssl and galera_sst_rsync_missing_stunnel only accepted exit codes 1,134 when the joiner mariadbd aborts SST, causing intermittent failures (e.g. on FreeBSD) where the process exits cleanly with 0. Solution: accept exit code 0 as well, matching the precedent already established in galera_sst_cn_injection.test / galera_sst_mariabackup_encrypt_with_key_server.test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: galera_sst_mariabackup_missing_ssl and galera_sst_rsync_missing_stunnel only accepted exit codes 1,134 when the joiner mariadbd aborts SST, causing intermittent failures (e.g. on FreeBSD) where the process exits cleanly with 0.
Solution: accept exit code 0 as well, matching the precedent already established in galera_sst_cn_injection.test / galera_sst_mariabackup_encrypt_with_key_server.test.