Add a search control#1048
Merged
Merged
Conversation
prushforth
force-pushed
the
search-control
branch
3 times, most recently
from
6ca6f09 to
7dad670
Compare
Make icons a bit bolder to match the search icon which is paths of a certain width Add disabled support to search control. Bound to checked, but not bound to hidden. Update linux screenshots due to bolding of zoom, reload controls to match magnifying glass search control icon boldness. Remove now out of date win32 screenshots for same reason Make calculation of total size of controls omit the search control mostly, for backwards compatibility Add waitUntil: 'networkidle', increase some timeouts to de-flake some tests Implement custom search handler. Use geoname search as example. Add search example using geonames.org Search panel grabs focus on mouseenter Add localization messages for search button. Add localization and non-Latin character search tests. Add second search layer to index.html mapml-viewer (multiple search link handler) Change search default - clicking a suggestion triggers a search, navigation - panel stays open until user dismisses it - panel now requires 2 Esc / clicks to close it - update broken tests Simplify search events' API Add HTMLMapmlViewerElement.zoomToExtent(xmin,ymin,xmax,ymax) to support documentation change for custom search handler development De-flake a test Update markup skills to add search controlslist token De-flake a couple more tests Update win32 screen caps to account for bold control icons to match search icon boldness Clean up
Add playwright browser caching Prevent npm ci from installing browsers Ignore postinstall scripts
prushforth
force-pushed
the
search-control
branch
from
7dad670 to
4c5c211
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1040
Related requirement #258
Related spec update
Related documentation update
Related extension update
Related experiments