test(api): run the integration SQL catalog through the ClickHouse e2e sweep - #544
Merged
Conversation
… sweep collectIntegrationCatalog() was only consumed by the integrations package's own unit tests, so the Cloudflare/PlanetScale/AI fixtures never met the real analyzer — while a comment in catalog.ts claimed the sweep's 64-bit decode assertion covered them. Append the integration catalog to the sweep's entry list (both catalogs satisfy the same structural shape) and document the wiring in catalog.ts, making that claim true. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
🍁 Maple PR previewNote Preview resources were removed when this pull request closed. Final commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
collectIntegrationCatalog()from@maple/query-engine-integrations/catalogwas only consumed by the integrations package's own unit tests — the Cloudflare/PlanetScale/AI fixtures never ran through the real-ClickHouse analyzer sweep, while a comment incatalog.tsclaimed the sweep's quoted/unquoted 64-bit decode assertion covered them.sql-catalog.clickhouse.e2e.test.ts. The two catalogs are separate types (the core package must not import the integrations package), but both satisfy the small structural shape the sweep reads, captured as a localSweepEntryinterface. The core catalog is still deduped by fingerprint; the 12 integration fixtures are distinct shapes and are appended as-is.catalog.ts's header, which makes the existing ai-sessions row-schema comment accurate rather than aspirational.Testing
CLICKHOUSE_E2E=1): 157 tests passed, and the verbose reporter confirms all 12builder:*integration fixtures executed, including both 64-bit wire-shape decode passes for the AI-session fixtures that carry row schemas.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.