fix(api): give the v2 route harness the LiveActivitiesService its groups need - #539
Merged
Conversation
…ups need The mobile-devices group started requiring LiveActivitiesService when Live Activities landed, but the shared harness only provided MobileDevicesService. Every v2 route test builds the whole group set, so one missing service failed both API shards on main — ~150 tests across alerts, api_keys, config-resources, integrations and the alchemy provider integration, none of which touch push. It needs only the Database the harness already has, so it is provided for real alongside MobileDevicesService rather than stubbed.
🍁 Maple PR previewNote Preview resources were removed when this pull request closed. Final commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainis red on both API shards. The mobile-devices group started requiringLiveActivitiesServicewhen Live Activities landed, but the shared v2 routeharness only provided
MobileDevicesService.Every v2 route test builds the whole group set, so one missing service took out
~150 tests across alerts, api_keys, config-resources, integrations and the
alchemy provider integration — none of which touch push. They all failed with:
It needs only the Database the harness already provides, so it is wired for
real alongside
MobileDevicesServicerather than stubbed.Verified on a clean checkout of
mainplus this commit: the full API suitepasses, 2180 tests, 174 files.
This is the tail of #538, which merged about eight seconds after these shards
went red.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.