Repository navigation
OpenSecret: retire the legacy signed-PCR copy - #1659
Merged
Merged
Conversation
Signed PCR approvals were published twice: in this repository, which Research 3.4.0 and both SDKs at 4.0 read, and by hand in OpenSecretCloud/opensecret, which older clients read. Those older clients speak only Transport V1, which the backend no longer serves, so nothing that can reach a current backend reads the old copy. The procedure now publishes approvals here only and leaves the old repository as it is. It keeps one exception, with its command: a build from a commit that still serves Transport V1. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed PCR approvals no longer get published to the legacy copy in
OpenSecretCloud/opensecret. This is a documentation and procedure change; no code, workflow, PCR file or signing input changes.Why
Approvals have been published in two places: this repository, and by hand in the root of
OpenSecretCloud/opensecretfor clients that predate the monorepo. The second copy existed only for clients that read the old URLs.Both SDKs moved their history URLs to this repository on September 8, 2026 (
79774ba5). That commit is in Research 3.4.0 and in SDK 4.0.0 for TypeScript and Rust, the same releases that moved those clients to Transport V2. Everything older speaks only Transport V1, which #1647 removed from the backend. So no client that can still reach a current backend reads the old copy, and nothing in the current source reads the old URLs.Change
services/opensecret/docs/pcr-compatibility.mdis now "Signed PCR files": one public location, a section recording that the legacy copy is retired and why, and validation and publication checks for this repository only. The manual legacy-publication section is gone.Not changed
scripts/pcr_compatibility.pyand its tests. Itspreparecommand still serves the exception, and the file is a signing input..github/workflows/opensecret-eif-release.ymlthat says legacy mirror publication stays manual. I left the signing workflow untouched.🤖 Generated with Claude Code
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.