Repository navigation
Agent: name each ACP reasoning effort by id and label too - #1656
Merged
Merged
Conversation
The `models` extension listed a model's reasoning levels as
`{"value": ...}` entries. Paseo's parser requires `id` and `label` on each
entry, so it dropped every model's list and showed the startup model's
levels for all of them. A level picked there for a model that does not
accept it was saved, and the session could not be resumed afterwards
(getpaseo/paseo#10242).
Each entry now carries the level as `id`, `value` and `label`, the same
name the `thought_level` option shows.
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
AnthonyRonning
approved these changes
Nov 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
session/newandsession/loadlist each model's reasoning levels in themodelsextension as{"value": "low"}entries. Paseo's parser requiresidandlabelon every entry, so it rejected the whole list and fell back to the startup model's levels for every Maple model. Withglm-5-3as the startup model, every model was offeredlow/high/max.A user could then pick
maxforinkling-2-small, which tops out atxhigh. Paseo saved it, and once the idle runtime was collected the session could not be resumed:session/loadsucceeded, the follow-upthought_levelwrite was rejected with "This model does not support that thinking level", and Paseo discarded the resume. History looked lost and the level could not be changed from the UI.The Paseo side (a rejected saved level should not block resume) is reported in getpaseo/paseo#10242.
Change
Each
reasoningEffortsentry now carries the level asid,valueandlabel, the same name thethought_leveloption shows.valueis kept, so clients that read it are unaffected.docs/local-host.mddescribes the shape.Testing
session_setup_reports_every_models_reasoning_levelsnow asserts the full entry shape.cargo test -p maple-agent --lib acp::in the Agent Nix shell: 63 passed.Not verified: Paseo against a build with this change. The claim that Paseo then shows per-model levels rests on reading its installed 0.16.2 parser, which requires
idandlabeland readsvalue ?? id.Sessions already saved with an unsupported level stay broken until their Paseo record is corrected or Paseo handles the rejection.
🤖 Generated with Claude Code
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.