Skip to content

Agent: name each ACP reasoning effort by id and label too - #1656

Merged
w3irdrobot merged 1 commit into
masterfrom
codex-acpeffort-maple
Nov 19, 2026
Merged

w3irdrobot merged 1 commit into
masterfrom
codex-acpeffort-maple

Conversation

@w3irdrobot

@w3irdrobot w3irdrobot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Problem

session/new and session/load list each model's reasoning levels in the models extension as {"value": "low"} entries. Paseo's parser requires id and label on every entry, so it rejected the whole list and fell back to the startup model's levels for every Maple model. With glm-5-3 as the startup model, every model was offered low / high / max.

A user could then pick max for inkling-2-small, which tops out at xhigh. Paseo saved it, and once the idle runtime was collected the session could not be resumed: session/load succeeded, the follow-up thought_level write was rejected with "This model does not support that thinking level", and Paseo discarded the resume. History looked lost and the level could not be changed from the UI.

The Paseo side (a rejected saved level should not block resume) is reported in getpaseo/paseo#10242.

Change

Each reasoningEfforts entry now carries the level as id, value and label, the same name the thought_level option shows. value is kept, so clients that read it are unaffected. docs/local-host.md describes the shape.

Testing

  • session_setup_reports_every_models_reasoning_levels now asserts the full entry shape.
  • cargo test -p maple-agent --lib acp:: in the Agent Nix shell: 63 passed.
  • Pre-commit Agent gates (lint and workspace tests) passed.

Not verified: Paseo against a build with this change. The claim that Paseo then shows per-model levels rests on reading its installed 0.16.2 parser, which requires id and label and reads value ?? id.

Sessions already saved with an unsupported level stay broken until their Paseo record is corrected or Paseo handles the rejection.

🤖 Generated with Claude Code


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

The `models` extension listed a model's reasoning levels as
`{"value": ...}` entries. Paseo's parser requires `id` and `label` on each
entry, so it dropped every model's list and showed the startup model's
levels for all of them. A level picked there for a model that does not
accept it was saved, and the session could not be resumed afterwards
(getpaseo/paseo#10242).

Each entry now carries the level as `id`, `value` and `label`, the same
name the `thought_level` option shows.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@w3irdrobot
w3irdrobot marked this pull request as ready for review November 19, 2026 17:04
@w3irdrobot
w3irdrobot merged commit e5da60d into master Nov 19, 2026
23 checks passed
@w3irdrobot
w3irdrobot deleted the codex-acpeffort-maple branch November 19, 2026 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants