Skip to content

Agent: fix nightly heapless advisories (RUSTSEC-2026-0574 to 0582) - #1654

Merged
AnthonyRonning merged 1 commit into
masterfrom
fix/nightly-2026-11-19
Nov 19, 2026
Merged

AnthonyRonning merged 1 commit into
masterfrom
fix/nightly-2026-11-19

Conversation

@AnthonyRonning

@AnthonyRonning AnthonyRonning commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

What failed

Today's scheduled CI run 44533442138 (master b0da7a63) is red only in agent-supply-chain (ci-ok follows from it). No ci-nightly issue was open when this was written. The Nov 17 and Nov 18 scheduled runs were green.

cargo deny check advisories reports nine new unsound advisories against both heapless versions in apps/maple-agent/Cargo.lock: RUSTSEC-2026-0574 through RUSTSEC-2026-0582.

Root cause

RustSec published the nine heapless advisories on Nov 18, all patched only in heapless >= 0.9.4. The Agent lockfile holds two copies:

  • heapless 0.9.3, used by gpui and sum_tree.
  • heapless 0.7.17, used only by postcard 1.1.3. postcard requires heapless ^0.7, and there is no patched 0.7 or 0.8 release. The copy is in the graph because the pinned CUA cursor-overlay takes postcard with default features (heapless-cas); iroh-relay and regorus both set default-features = false.

Change

  • heapless 0.9.3 -> 0.9.4 in apps/maple-agent/Cargo.lock. No other lockfile entry changed; 0.9.4 has the same dependencies as 0.9.3.
  • Nine reviewed ignores in apps/maple-agent/deny.toml for the 0.7.17 copy, with the reasoning in a comment above them. Since the other copy is now on the patched release, these ids can only match 0.7.17.

Why the 0.7.17 copy is not reachable:

  • The advisories cover sorted_linked_list, spsc, IndexMap, Deque, HistoryBuf, the pools and vec::IntoIter::drop.
  • postcard's non-test code uses only heapless::Vec<u8, N> push / extend_from_slice (the HVec flavor) and MaxSize impls for Vec and String. IndexMap appears only in its own tests.
  • The consumers do not call those entry points: cursor-overlay, iroh, iroh-relay and regorus use to_allocvec, to_stdvec, to_io and from_bytes only. Nothing in apps/maple-agent uses postcard or heapless directly.

Cooldown bypass

  • Package: heapless 0.9.4, published 2026-11-18T12:54:52Z, one day old, so under the seven-day cooldown.
  • Reason: it is the security fix release for RUSTSEC-2026-0574 through 0582 and the only patched version.
  • Scope: this one cargo update -p heapless@0.9.3 --precise 0.9.4. No persistent setting changed.

Verification

  • python3 scripts/audit-sqlcipher-dependencies.py in the Agent Nix shell: advisories ok, bans ok on all four targets.
  • Control: with only the lockfile bump and no ignores, the same command still failed on heapless 0.7.17.
  • The pre-commit hook's Agent checks passed (489s).
  • Not run here: the rest of just supply-chain, since verify_sqlcipher.py does not link on this Mac. This PR does not touch what it checks.

Open decisions

  • The ignores stay until postcard moves off heapless 0.7 or CUA stops enabling postcard's default features. Asking CUA to set default-features = false on postcard would remove the 0.7.17 copy altogether; that needs an upstream change and a pin bump, so it is not in this PR.
  • The reachability review is by source reading, not by a build with the heapless feature off.

🤖 Generated with Claude Code


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

RustSec published RUSTSEC-2026-0574 through 0582 (heapless unsoundness)
on Nov 18, failing agent-supply-chain for both heapless versions in the
Agent lockfile.

- heapless 0.9.3 -> 0.9.4 (gpui, sum_tree): the patched release.
- heapless 0.7.17 has no patched 0.7 release and is only pulled in by
  postcard 1.1.3's default feature via the pinned CUA cursor-overlay.
  None of the affected APIs are reachable, so the nine ids get reviewed
  ignores in deny.toml.

Co-Authored-By: Claude <noreply@anthropic.com>
@AnthonyRonning
AnthonyRonning merged commit c3db496 into master Nov 19, 2026
26 checks passed
@AnthonyRonning
AnthonyRonning deleted the fix/nightly-2026-11-19 branch November 19, 2026 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant