Repository navigation
Agent: fix nightly heapless advisories (RUSTSEC-2026-0574 to 0582) - #1654
Merged
Merged
Conversation
RustSec published RUSTSEC-2026-0574 through 0582 (heapless unsoundness) on Nov 18, failing agent-supply-chain for both heapless versions in the Agent lockfile. - heapless 0.9.3 -> 0.9.4 (gpui, sum_tree): the patched release. - heapless 0.7.17 has no patched 0.7 release and is only pulled in by postcard 1.1.3's default feature via the pinned CUA cursor-overlay. None of the affected APIs are reachable, so the nine ids get reviewed ignores in deny.toml. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What failed
Today's scheduled CI run 44533442138 (master
b0da7a63) is red only inagent-supply-chain(ci-okfollows from it). Noci-nightlyissue was open when this was written. The Nov 17 and Nov 18 scheduled runs were green.cargo deny check advisoriesreports nine newunsoundadvisories against bothheaplessversions inapps/maple-agent/Cargo.lock: RUSTSEC-2026-0574 through RUSTSEC-2026-0582.Root cause
RustSec published the nine
heaplessadvisories on Nov 18, all patched only inheapless >= 0.9.4. The Agent lockfile holds two copies:heapless 0.9.3, used bygpuiandsum_tree.heapless 0.7.17, used only bypostcard 1.1.3.postcardrequiresheapless ^0.7, and there is no patched 0.7 or 0.8 release. The copy is in the graph because the pinned CUAcursor-overlaytakespostcardwith default features (heapless-cas);iroh-relayandregorusboth setdefault-features = false.Change
heapless 0.9.3 -> 0.9.4inapps/maple-agent/Cargo.lock. No other lockfile entry changed; 0.9.4 has the same dependencies as 0.9.3.apps/maple-agent/deny.tomlfor the 0.7.17 copy, with the reasoning in a comment above them. Since the other copy is now on the patched release, these ids can only match 0.7.17.Why the 0.7.17 copy is not reachable:
sorted_linked_list,spsc,IndexMap,Deque,HistoryBuf, the pools andvec::IntoIter::drop.postcard's non-test code uses onlyheapless::Vec<u8, N>push/extend_from_slice(theHVecflavor) andMaxSizeimpls forVecandString.IndexMapappears only in its own tests.cursor-overlay,iroh,iroh-relayandregorususeto_allocvec,to_stdvec,to_ioandfrom_bytesonly. Nothing inapps/maple-agentusespostcardorheaplessdirectly.Cooldown bypass
heapless 0.9.4, published 2026-11-18T12:54:52Z, one day old, so under the seven-day cooldown.cargo update -p heapless@0.9.3 --precise 0.9.4. No persistent setting changed.Verification
python3 scripts/audit-sqlcipher-dependencies.pyin the Agent Nix shell:advisories ok, bans okon all four targets.heapless 0.7.17.just supply-chain, sinceverify_sqlcipher.pydoes not link on this Mac. This PR does not touch what it checks.Open decisions
postcardmoves offheapless 0.7or CUA stops enablingpostcard's default features. Asking CUA to setdefault-features = falseonpostcardwould remove the 0.7.17 copy altogether; that needs an upstream change and a pin bump, so it is not in this PR.heaplessfeature off.🤖 Generated with Claude Code
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.