Skip to content

Research: retire the hosted V1 desktop sign-in bundle - #1649

Merged
AnthonyRonning merged 1 commit into
masterfrom
remove-legacy-desktop-oauth
Nov 19, 2026
Merged

AnthonyRonning merged 1 commit into
masterfrom
remove-legacy-desktop-oauth

Conversation

@AnthonyRonning

@AnthonyRonning AnthonyRonning commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Removes Research's hosted Transport V1 desktop sign-in bundle. Follows #1647, which removes Transport V1 from the backend.

Why

Releases before 3.4.0 open /desktop-auth with no transport parameter. Research answered those by loading a second bundle built on the pinned @opensecret/react 3.4.1, which speaks only Transport V1. Once the backend stops serving V1, that bundle cannot sign anyone in.

Change

  • /desktop-auth with no transport selector now shows a small notice, "Update Maple to sign in", with a link to the download page, instead of the application. It loads as its own 0.6 kB chunk, without the app bundle or the SDK.
  • Any supplied selector, including a malformed one, still goes to the application, which accepts only v2 and fails closed on the rest. That behaviour is unchanged.
  • OAuth callbacks are no longer inspected for a pre-V2 flow; they always go to the application. The localStorage markers that old flow wrote are removed at startup. Before, a stale marker from an abandoned old sign-in would send an ordinary web sign-in callback to the legacy bundle.
  • @opensecret/react-v1 is removed from the manifest. The lockfile loses exactly that entry and nothing else changes version.

What users of old releases see

Once this is published, a pre-3.4.0 desktop client that starts Google, GitHub or Apple sign-in lands on the update notice. This does not depend on the backend change being deployed. A sign-in that such a client started just before the deploy and finishes just after it fails with the application's normal sign-in error rather than the notice; that window is one deploy long.

Checked

  • research-web lane locally: lint (no errors), typecheck, 1,202 tests, and both builds pass.
  • In a browser against the built site: /desktop-auth?provider=github shows the notice; /desktop-auth?provider=github&transport=invalid shows the application's "Unsupported desktop authentication transport" error; with stale V1 markers set, /login loads the application and the markers are gone.

Not checked: a real pre-3.4.0 desktop build opening the page, or the page as served from the production host.

Left alone

apps/maple-auth/README.md still says Research keeps a legacy native bridge. Editing anything under apps/maple-auth/ runs Auth's Pages CI, so that line can go with the next real Auth change. Auth's own build guard against bundling the old @opensecret/* SDK is unchanged.

🤖 Generated with Claude Code


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

@github-actions

Copy link
Copy Markdown
Contributor

Maple development preview: https://753e4e60.maple-ca8.pages.dev

Commit: d52596d96a0b690c7c48472d325b4e0cfa5677bc

Uses development API, billing, flags and PCR configuration. Cloudflare Access applies.

Releases before 3.4.0 open /desktop-auth without a transport selector, and
Research answered by loading a second bundle built on the pinned
@opensecret/react 3.4.1, which speaks Transport V1. The backend is dropping
Transport V1, so that bundle can no longer sign anyone in.

Such a request now gets a small notice that this version of Maple is no
longer supported, with a link to the download page, instead of the
application. Requests that carry any transport selector still go to the
application, which accepts only v2 and fails closed on the rest.

OAuth callbacks are no longer inspected for a pre-V2 flow. They always go
to the application, and the localStorage markers that old flow left behind
are removed at startup, so a stale marker cannot capture an ordinary web
sign-in.

Removes the @opensecret/react-v1 alias; the lockfile loses exactly that
entry.

Co-Authored-By: Claude <noreply@anthropic.com>
@AnthonyRonning
AnthonyRonning force-pushed the remove-legacy-desktop-oauth branch from d52596d to 3d6af56 Compare November 19, 2026 19:56
@AnthonyRonning
AnthonyRonning merged commit 1096752 into master Nov 19, 2026
23 checks passed
@AnthonyRonning
AnthonyRonning deleted the remove-legacy-desktop-oauth branch November 19, 2026 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant