Repository navigation
chore(ci): update GitHub Actions dependencies - #1593
Conversation
|
Maple Auth development preview: https://53b3775b.maple-auth-dev.pages.dev Commit: Uses development services. Cloudflare Access applies. Provider OAuth is not configured for PR URLs; use the stable Auth Dev host for OAuth rehearsal. |
|
Maple development preview: https://96f431cc.maple-ca8.pages.dev Commit: Uses development API, billing, flags and PCR configuration. Cloudflare Access applies. |
|
I merged in the sqlite stuff after validating it's upgrade path across win/lin/mac. could you rebase and see if that fixes the cicd failures? |
8a883cd to
a8f16c9
Compare
AnthonyRonning
left a comment
There was a problem hiding this comment.
Reviewed all 17 action upgrades against Maple usage, upstream source changes, manifests, and dependency advisories. No blocking regressions found. Independently passed all seven root flake checks and verified dev/prod EIF PCR0/1/2 against existing approvals; PR CI has 43 successful and 3 skipped checks. Signing, publishing, and upgraded CodeQL execution remain integration limits; retained transitive advisories were assessed without establishing a reachable exploit in the inspected Maple paths.
Updates 17 reviewed GitHub Actions dependencies in one PR: two patch, five minor, and ten major updates. Each major update was added individually and checked in CI before the next one.
Included updates:
Swatinem/rust-cache→ v2.9.3 andrust-lang/crates-io-auth-action→ v1.0.6.DeterminateSystems/flakehub-cache-action→ v3.24.2,actions/attest→ v4.2.2,azure/login→ v3.1.0, andgithub/codeql-action→ v4.39.3.DeterminateSystems/determinate-nix-action, all 47 runtimesource-tagpins, verifier, policy constants, and documentation → Determinate Nix 3.24.2 / upstream Nix 2.35.3.actions/checkout→ v7.0.1,actions/cache→ v6.1.0,actions/upload-artifact→ v7.0.2,actions/download-artifact→ v8.0.2,actions/setup-go→ v7.0.0,actions/setup-node→ v7.1.0,docker/build-push-action→ v7.4.0,docker/login-action→ v4.8.0,docker/setup-buildx-action→ v4.4.1,oven-sh/setup-bun→ v2.2.0. Only action SHAs and version comments change for these updates; existing inputs and conditions are preserved.The factual audit below covers the full reviewed set, including updates not yet added. Untagged snapshots remain outside the versioned update set. PRs #1595 and #1596 are superseded by this combined PR.
Patch review
Swatinem/rust-cache
The old pin is one commit after v2.9.1. v2.9.2 fixes Windows cache-path validation and improves Cargo fingerprint, library-target, and build-directory caching. v2.9.3 fixes stale-entry cleanup and improves diagnostics. The inputs Maple uses, the
cache-hitoutput, and the Node 24 runtime remain compatible. CI's master/schedule-only save policy and lane/vendor cache boundaries remain unchanged.No new, confirmed vulnerability remediation was identified for this interval; the documented fixes concern correctness and reliability. Cache hit rate and actual save/restore operation remain runtime checks rather than conclusions from the manifest comparison.
Sources: v2.9.2, v2.9.3, source comparison.
rust-lang/crates-io-auth-action
v1.0.6 is dependency maintenance. The action manifest is identical to v1.0.5: the default crates.io URL,
tokenoutput, Node 24 runtime, and OIDC permission requirements are unchanged. Maple's one trusted-publishing use passes no custom inputs and consumes the same token output.No published advisory was found for the action in this interval; an empty advisory list does not prove the absence of security-relevant changes. The dependency/bundle refresh is not presented here as confirmed CVE remediation.
The publisher's
dry_run=truepath skips the publishing job, so it does not exercise this action or prove an OIDC token exchange.Sources: v1.0.6, source comparison.
Broader workflow review — 2026-11-12
The audit covered 30 workflows and four composite actions at Maple master
4090b9be0fe3c1ff1e6f889071e72da71d3813fe. Separate engineering reviews compared 17 versioned action updates and two untagged snapshots against actual Maple usage. The following records the compatibility findings. The current implementation scope is listed above.Cross-cutting compatibility findings
source-tagpins the installed runtime separately from its wrapper SHA. A wrapper-only update retains the old runtime. Moving the runtime without updatingverify-nix-runtime.shcauses exact-version failures. Runtime source tags, verifier, policy constants, and documentation form one coordinated contract. EIF reproducibility remains separate evidence; cache success or an upstream compatibility claim does not prove PCR equality.archive: truekeeps existing ZIP consumers compatible.bun-prefix plus a URL hash, and changes downloads to GitHub release assets. A cache miss/redownload is possible after the upgrade; an already installed matching binary can avoid it. The selected Bun compiler/runtime version remains 1.3.5.continue-on-errorcan fail while its workflow remains green.Security findings
Review limits
The initial dependency audit used source/API comparisons and selected existing job logs. Subsequent PR validation below records the upgraded action execution that was actually exercised. Signing/publishing and every configured runner override remain unverified. No workflow redesign was demonstrated as necessary for the reviewed Maple usage. The static findings do not substitute for runtime cache, artifact, OIDC, or publishing integration evidence.
Validation
Rebased onto master
9604dc8f345bto include SQLCipher 4.20.0 / SQLite 3.54.1 from #1597. All 13 dependency-update commits replayed without conflicts and have identical patches.ci-okcheck passed.agent-supply-chainpassed: the earlier SQLCipher advisory failure is resolved on this rebased head.Before rebasing onto master
Final Bun validation: Windows packaging successfully installed Bun 1.3.5 through setup-bun v2.2.0, and its post step kept caching disabled on the PR. Final dev/prod EIF PCR0/1/2 and exact image hashes match the existing approved references.
Latest major update (
oven-sh/setup-bunv2.2.0) completed CI with 41 passed checks and 3 skipped. Only the confirmed existing SQLCipher advisory and derivedci-okfailed. CI run.The patch, minor, and coordinated Nix changes passed local repository checks before consolidation. Every major update passed all seven root flake checks and the normal 574-test pre-commit hook before its push.
Passed
just lane repoon the combined tree: all seven root flake checks, actionlint, and 574 CI contract/policy tests (two skipped in Nix). Passedgit diff --check.Earlier patch/minor/Nix CI runs completed with only the existing SQLCipher advisory failure (
RUSTSEC-2026-0502) and its derivedci-okfailure. Those raw failure statuses remain intact.Earlier minor and Nix EIF candidate jobs passed for dev and prod and matched approved measurements. Nix 3.24.2 preserved the filtered source NAR hash and both EIF derivation paths.
Combined-tree CI run 43288413998 has passed both checkout EIF candidates: dev/prod image hashes and PCR0/1/2 match the existing references, and the installed Nix runtime matches 3.24.2 / 2.35.3. 32 checks passed and 12 were skipped; only the confirmed existing SQLCipher advisory and its derived verdict failed. All ten major updates completed their individual CI runs without a new failure.
Artifact updates each passed all platform packaging rehearsals: upload CI and download CI, each with 41 passed checks and only the existing SQLCipher/derived verdict failures. This includes native Windows ARM64. The macOS package verified the Metal Toolchain download digest using download-artifact v8 and uploaded its finished unsigned package using upload-artifact v7.
Publishing, signing, master-only CodeQL execution, and every configured runner override remain unverified by PR checks. No signing, publishing, or release workflow was manually dispatched.
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.