Skip to content

chore(ci): update GitHub Actions dependencies - #1593

Merged
AnthonyRonning merged 13 commits into
masterfrom
codex-cipatch13-maple
Nov 13, 2026
Merged

AnthonyRonning merged 13 commits into
masterfrom
codex-cipatch13-maple

Conversation

@w3irdrobot

@w3irdrobot w3irdrobot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Updates 17 reviewed GitHub Actions dependencies in one PR: two patch, five minor, and ten major updates. Each major update was added individually and checked in CI before the next one.

Included updates:

  • Patch: Swatinem/rust-cache → v2.9.3 and rust-lang/crates-io-auth-action → v1.0.6.
  • Minor: DeterminateSystems/flakehub-cache-action → v3.24.2, actions/attest → v4.2.2, azure/login → v3.1.0, and github/codeql-action → v4.39.3.
  • Coordinated Nix update: DeterminateSystems/determinate-nix-action, all 47 runtime source-tag pins, verifier, policy constants, and documentation → Determinate Nix 3.24.2 / upstream Nix 2.35.3.
  • Major: actions/checkout → v7.0.1, actions/cache → v6.1.0, actions/upload-artifact → v7.0.2, actions/download-artifact → v8.0.2, actions/setup-go → v7.0.0, actions/setup-node → v7.1.0, docker/build-push-action → v7.4.0, docker/login-action → v4.8.0, docker/setup-buildx-action → v4.4.1, oven-sh/setup-bun → v2.2.0. Only action SHAs and version comments change for these updates; existing inputs and conditions are preserved.

The factual audit below covers the full reviewed set, including updates not yet added. Untagged snapshots remain outside the versioned update set. PRs #1595 and #1596 are superseded by this combined PR.

Patch review

Swatinem/rust-cache

The old pin is one commit after v2.9.1. v2.9.2 fixes Windows cache-path validation and improves Cargo fingerprint, library-target, and build-directory caching. v2.9.3 fixes stale-entry cleanup and improves diagnostics. The inputs Maple uses, the cache-hit output, and the Node 24 runtime remain compatible. CI's master/schedule-only save policy and lane/vendor cache boundaries remain unchanged.

No new, confirmed vulnerability remediation was identified for this interval; the documented fixes concern correctness and reliability. Cache hit rate and actual save/restore operation remain runtime checks rather than conclusions from the manifest comparison.

Sources: v2.9.2, v2.9.3, source comparison.

rust-lang/crates-io-auth-action

v1.0.6 is dependency maintenance. The action manifest is identical to v1.0.5: the default crates.io URL, token output, Node 24 runtime, and OIDC permission requirements are unchanged. Maple's one trusted-publishing use passes no custom inputs and consumes the same token output.

No published advisory was found for the action in this interval; an empty advisory list does not prove the absence of security-relevant changes. The dependency/bundle refresh is not presented here as confirmed CVE remediation.

The publisher's dry_run=true path skips the publishing job, so it does not exercise this action or prove an OIDC token exchange.

Sources: v1.0.6, source comparison.

Broader workflow review — 2026-11-12

The audit covered 30 workflows and four composite actions at Maple master 4090b9be0fe3c1ff1e6f889071e72da71d3813fe. Separate engineering reviews compared 17 versioned action updates and two untagged snapshots against actual Maple usage. The following records the compatibility findings. The current implementation scope is listed above.

Class Action Audited comparison Compatibility finding
Major actions/checkout 4.3.1 → 7.0.1 Trusted checkout refs remain compatible with the new fork-PR restriction. All current checkout steps disable credential persistence.
Major actions/cache 4.3.0 → 6.1.0 Restore/save interfaces and cache-version calculation remain compatible; existing keys and conditional save policies remain valid.
Major actions/upload-artifact 4.6.2 → 7.0.2 Default ZIP format, names, paths, and output contracts remain compatible. New direct uploads are opt-in and unused.
Major actions/download-artifact 4.3.0 → 8.0.2 Current artifact counts preserve existing layouts; single-match flattening and stricter digest handling are detailed below.
Major actions/setup-go 5.6.0 → 7.0.0 The explicit Go version remains supported. The historical form-data fix is already present in the pinned v5 backport, so it is not new remediation for Maple.
Major actions/setup-node 6.5.0 → 7.1.0 Maple's explicit npm configuration and bootstrap/trusted authentication do not depend on the removed dummy NODE_AUTH_TOKEN value.
Major docker/build-push-action 5.4.0 → 7.4.0 Existing build inputs and digest output remain compatible, including use with the currently pinned companion actions.
Major docker/login-action 3.7.0 → 4.8.0 GHCR username/token login, logout, and downstream Docker CLI credential use remain compatible. New Docker Hub OIDC paths are unused.
Major docker/setup-buildx-action 3.12.0 → 4.4.1 Maple's three default-input builder setups remain compatible with build/push and imagetools consumers.
Major oven-sh/setup-bun 1.2.2 → 2.2.0 Explicit Bun 1.3.5 selection remains supported. Registry deprecations do not affect Maple. Cache keys and download URL routing change.
Minor DeterminateSystems/determinate-nix-action 3.23.3 → 3.24.2 The wrapper interface remains compatible, but the installed runtime is separately pinned and enforced by exact-version checks.
Minor DeterminateSystems/flakehub-cache-action 3.20.0 → 3.24.2 Existing diff-store, permissions, and event boundaries remain compatible. Cache operation remains a runtime check.
Minor actions/attest 4.1.0 → 4.2.2 Existing manifests, subject inputs, outputs, and Windows CRLF handling remain compatible. Some sites tolerate attestation errors.
Minor azure/login 3.0.0 → 3.1.0 OIDC and downstream Azure CLI signing usage remain compatible. PowerShell-specific hardening affects a path Maple does not enable.
Minor github/codeql-action 4.38.0 → 4.39.3 Current languages and inputs remain compatible; updated CLI/query packs can change findings.
Patch Swatinem/rust-cache post-2.9.1 → 2.9.3 Implemented in this PR; detailed above.
Patch rust-lang/crates-io-auth-action 1.0.5 → 1.0.6 Implemented in this PR; detailed above.
Snapshot DeterminateSystems/magic-nix-cache-action 3c034b5, between v13/v14 → v15 Existing inputs and untrusted-job boundary remain compatible. Maple's separately pinned daemon revision remains unchanged.
Snapshot dtolnay/rust-toolchain 29eef336 → b725eda5 Composite Bash action remains compatible with explicit compiler versions; adds shell-input hardening, narrow retries, and non-host toolchain support.

Cross-cutting compatibility findings

  • Several major updates move their JavaScript runtime to Node 24 and require Actions Runner >=2.327.1. Existing successful job logs establish support for sampled runner classes, including Blacksmith macOS, but do not establish every configured runner override. The Rust-toolchain action is composite Bash and has no Node runtime requirement; its added rustup flags require support in the effective rustup installation.
  • The Nix action's source-tag pins the installed runtime separately from its wrapper SHA. A wrapper-only update retains the old runtime. Moving the runtime without updating verify-nix-runtime.sh causes exact-version failures. Runtime source tags, verifier, policy constants, and documentation form one coordinated contract. EIF reproducibility remains separate evidence; cache success or an upstream compatibility claim does not prove PCR equality.
  • Download-artifact v8 flattens unnamed/pattern downloads when exactly one artifact matches. Android verification and Agent publishing currently receive multiple artifacts and retain their nested directories; their consumers would become incompatible if the match count dropped to one. Android proof filenames overlap across artifacts, so flattening/merging them would not preserve the existing contract.
  • Download-artifact v8 changes digest mismatch handling from a warning to an error. Sampled existing downloads had matching digests. Upload-artifact's default archive: true keeps existing ZIP consumers compatible.
  • Setup-bun changes cache keys to a bun- prefix plus a URL hash, and changes downloads to GitHub release assets. A cache miss/redownload is possible after the upgrade; an already installed matching binary can avoid it. The selected Bun compiler/runtime version remains 1.3.5.
  • Magic Nix Cache and FlakeHub retain non-strict caching behavior. A green build alone cannot establish successful substitutions or uploads. Likewise, an attestation step with continue-on-error can fail while its workflow remains green.

Security findings

  • Determinate Nix's runtime update includes Brotli decoder and certificate-trust fixes affecting cache/input fetching. These arrive through the installed runtime, not merely the wrapper SHA. Sources: 3.24.1 runtime release, 3.24.0 runtime release, installer release.
  • Download-artifact's bundled unzip-stream moves beyond the ZIP path-traversal fix. The review did not test exploitation. Sources: advisory, target release.
  • Build/push fixes workflow-command injection through metadata logging. It also includes secret-summary and Git credential-scoping hardening; Maple does not use every affected path. Source: metadata logging fix.
  • CodeQL, Docker, attestation, and cache actions include transitive dependency remediation. Affected-to-fixed dependency transitions are distinct from demonstrated exploitation in Maple; several relevant feature paths are unused.
  • Some audited targets retain transitive advisories, including cache-helper HTTP/XML dependencies and dependencies in attestation and Docker tooling. The reviews do not establish complete vulnerability remediation or reachability of every advisory. Setup-bun's old resolved form-data version was not established, so its release-note security claim remains qualified.

Review limits

The initial dependency audit used source/API comparisons and selected existing job logs. Subsequent PR validation below records the upgraded action execution that was actually exercised. Signing/publishing and every configured runner override remain unverified. No workflow redesign was demonstrated as necessary for the reviewed Maple usage. The static findings do not substitute for runtime cache, artifact, OIDC, or publishing integration evidence.

Validation

Rebased onto master 9604dc8f345b to include SQLCipher 4.20.0 / SQLite 3.54.1 from #1597. All 13 dependency-update commits replayed without conflicts and have identical patches.

  • Passed all seven local root flake checks, workflow classification, and whitespace checks.
  • Rebased CI: passed; 43 passed, 3 skipped, 0 pending, 0 failed. The required ci-ok check passed.
  • agent-supply-chain passed: the earlier SQLCipher advisory failure is resolved on this rebased head.
  • Both EIF candidates match the current master approvals for PCR0/1/2 and run the expected Determinate Nix 3.24.2 / Nix 2.35.3 runtime.

Before rebasing onto master

  • Final Bun validation: Windows packaging successfully installed Bun 1.3.5 through setup-bun v2.2.0, and its post step kept caching disabled on the PR. Final dev/prod EIF PCR0/1/2 and exact image hashes match the existing approved references.

  • Latest major update (oven-sh/setup-bun v2.2.0) completed CI with 41 passed checks and 3 skipped. Only the confirmed existing SQLCipher advisory and derived ci-ok failed. CI run.

  • The patch, minor, and coordinated Nix changes passed local repository checks before consolidation. Every major update passed all seven root flake checks and the normal 574-test pre-commit hook before its push.

  • Passed just lane repo on the combined tree: all seven root flake checks, actionlint, and 574 CI contract/policy tests (two skipped in Nix). Passed git diff --check.

  • Earlier patch/minor/Nix CI runs completed with only the existing SQLCipher advisory failure (RUSTSEC-2026-0502) and its derived ci-ok failure. Those raw failure statuses remain intact.

  • Earlier minor and Nix EIF candidate jobs passed for dev and prod and matched approved measurements. Nix 3.24.2 preserved the filtered source NAR hash and both EIF derivation paths.

  • Combined-tree CI run 43288413998 has passed both checkout EIF candidates: dev/prod image hashes and PCR0/1/2 match the existing references, and the installed Nix runtime matches 3.24.2 / 2.35.3. 32 checks passed and 12 were skipped; only the confirmed existing SQLCipher advisory and its derived verdict failed. All ten major updates completed their individual CI runs without a new failure.

  • Artifact updates each passed all platform packaging rehearsals: upload CI and download CI, each with 41 passed checks and only the existing SQLCipher/derived verdict failures. This includes native Windows ARM64. The macOS package verified the Metal Toolchain download digest using download-artifact v8 and uploaded its finished unsigned package using upload-artifact v7.

  • Publishing, signing, master-only CodeQL execution, and every configured runner override remain unverified by PR checks. No signing, publishing, or release workflow was manually dispatched.


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

@w3irdrobot w3irdrobot added the ci:eif Run the OpenSecret EIF PR candidate build label Nov 12, 2026
@w3irdrobot w3irdrobot changed the title chore(ci): update Rust cache and crates.io auth patch pins chore(ci): update GitHub Actions dependencies Nov 12, 2026
@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Maple Auth development preview: https://53b3775b.maple-auth-dev.pages.dev

Commit: a8f16c99bcf406e9addf9594947374d3db41d700

Uses development services. Cloudflare Access applies. Provider OAuth is not configured for PR URLs; use the stable Auth Dev host for OAuth rehearsal.

@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Maple development preview: https://96f431cc.maple-ca8.pages.dev

Commit: a8f16c99bcf406e9addf9594947374d3db41d700

Uses development API, billing, flags and PCR configuration. Cloudflare Access applies.

@w3irdrobot w3irdrobot added the ci:package Build unsigned packages on this PR label Nov 12, 2026
@w3irdrobot w3irdrobot removed the ci:package Build unsigned packages on this PR label Nov 12, 2026
@w3irdrobot w3irdrobot added the ci:package Build unsigned packages on this PR label Nov 12, 2026
@AnthonyRonning

Copy link
Copy Markdown
Contributor

I merged in the sqlite stuff after validating it's upgrade path across win/lin/mac.

could you rebase and see if that fixes the cicd failures?

@AnthonyRonning AnthonyRonning left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all 17 action upgrades against Maple usage, upstream source changes, manifests, and dependency advisories. No blocking regressions found. Independently passed all seven root flake checks and verified dev/prod EIF PCR0/1/2 against existing approvals; PR CI has 43 successful and 3 skipped checks. Signing, publishing, and upgraded CodeQL execution remain integration limits; retained transitive advisories were assessed without establishing a reachable exploit in the inspected Maple paths.

@AnthonyRonning
AnthonyRonning merged commit 38445c2 into master Nov 13, 2026
46 checks passed
@AnthonyRonning
AnthonyRonning deleted the codex-cipatch13-maple branch November 13, 2026 22:30

This branch was successfully deployed

2 active deployments
pages-pr-1593 — a8f16c99 Deployed Nov 13, 2026 by github-actions[bot]
auth-pages-pr-1593 — a8f16c99 Deployed Nov 13, 2026 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:eif Run the OpenSecret EIF PR candidate build ci:package Build unsigned packages on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants