Repository navigation
Agent: List the files a turn changed under its reply - #1590
Open
matthewrball wants to merge 12 commits into
Open
matthewrball wants to merge 12 commits into
matthewrball wants to merge 12 commits into
Conversation
With a turn's steps folded, what Maple changed was only visible by opening them and reading each edit. Once a turn is over, its reply carries a card: how many files changed, each file with the lines added and removed, and the diff on a click. It adds up the turn's edits and writes that went through, from the diffs their steps already derive, and is built once per turn.
# Conflicts: # apps/maple-agent/app/src/ui/chat/transcript.rs # apps/maple-agent/app/src/ui/chat/turn.rs
The card added up the lines kept for display, which stop at a cap, so a large write was undercounted. It now counts from each call's whole input, as the steps do.
# Conflicts: # apps/maple-agent/app/src/ui/chat/turn.rs
Loading a paged row's whole input left the card with the counts of the cut one, and a queued message ended a turn without the reply's row being measured for its new card. Both now drop the cached card and measure the row again. The card also asks only its edit and write steps for their derived rows, so a turn of commands derives nothing to learn it changed no file.
This was referenced Nov 12, 2026
# Conflicts: # apps/maple-agent/app/src/ui/chat/transcript.rs
matthewrball
marked this pull request as ready for review
November 12, 2026 15:14
Brings in master, independent activity chunks and the Korean catalog. A turn's reply and its files-changed card follow the turn's first step, whichever chunk the later steps are in; adds the Korean files-changed string.
…iles from the keyboard An empty streamed message took the reply's place and drew nothing, so the card vanished. A file row had no tab stop, key handler or focus ring, and its name was not in the accessibility tree.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
The first row is a headless render with fixture rows. The second is a signed-in run of this branch (the whole stack) in a debug build.
Notes
Turns::turn_of).a_turns_changes_add_up_by_file,a_turn_that_only_ran_commands_changed_nothing,a_turns_reply_is_what_maple_says_after_its_last_step,a_finished_turn_lists_what_it_changed_under_its_reply(the card appears when the run ends and the reply's row grows to hold it and an opened file).just ci-lintandcargo test -p maple-agent-app --lockedpass on each of the four branches, andjust ci-extraat the top of the stack (Agent: List the files a turn changed under its reply #1590). Partial verification:just ci-testwas not run to the end here; on this Mac it fails 65 store and external-agent tests incrates/maple-agent, which this stack does not touch.