Repository navigation
Introduce CMake as the Primary Build System for MapWinGIS6 - #70
Conversation
- Make CMake the default contributor build path - Document CLion, CTest, and legacy MSBuild workflows - Record the legacy-build review gate Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟡 Changes recommended
The documentation drops required legacy ActiveX validation before CMake supports that suite and gives misleading activation-verification and SDK-selection guidance.
3 open issues
What changed in this PR
Makes CMake the documented primary native build for MapWinGIS6 while retaining MSBuild during the transition. This PR changes documentation only.
Changes:
- Updates build and test instructions to use CMake presets and CTest.
- Expands prerequisites, IDE setup, optional sample targets, and troubleshooting guidance.
- Defines the legacy-build removal gate, including four consecutive weeks of green CI and a 2027-01-15 review target.
Native builds and tests were not run during this review.
| File | Description |
|---|---|
| README.md | Makes CMake the quick-start workflow and preserves MSBuild instructions. |
| docs/TESTING.md | Expands CTest commands, reporting, and CLion test guidance. |
| docs/CMAKE-MIGRATION.md | Records the legacy-build decision gate and outstanding verification. |
| docs/BUILDING.md | Documents CMake setup, dependencies, IDE workflows, and troubleshooting. |
| AGENTS.md | Changes the standard validation workflow to CMake and non-interactive CTest. |
Review effort: Balanced
Julian-MW
left a comment
Julian-MW
left a comment
There was a problem hiding this comment.
Automated review. Final decision is with the human reviewer.
Notes on out-of-diff locations (not line-commentable): docs/BUILDING.md ~line 154 "Output: bin<Configuration><Platform>" in the general "Configurations and platforms" table is MSBuild-specific output; consider noting CMake's out\b layout there. docs/TESTING.md lines 11–21 "## Running" documents only the legacy test executables; consider scoping it to the MSBuild build now that CTest is the primary path.
- Clarify CMake and legacy ActiveX test coverage. - Correct SDK, activation, CMake variable, and output guidance. - Align CTest preset examples and scope legacy test instructions. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Motivation
Make CMake the documented primary native build while keeping the legacy MSBuild workflow available during transition.
Changes
Validation
git diff --checkand local Markdown link-target checks passed.