Repository navigation
Pass image URLs straight to ImageIcon in the samples - #42
Merged
Merged
Conversation
The post-office markers and the weather icon on the marker icons page no longer load their images first; ImageIcon takes the URL and redraws the markers once the image arrives. Needs js-sdk-core feat/image-icon-url.
MapConductor/js-sdk-core#24 lets ImageIcon take an image URL, which the samples now use.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses the new
new ImageIcon(url, …)from MapConductor/js-sdk-core#24 (merged) and pointsjs-sdk-coreat that merge.new ImageIcon(markerImageUrl, …)instead of loading the image first.new ImageIcon(WEATHER_ICON_URL, …).Verified in headless Chrome on MapLibre and Google Maps: 24,526 tiled post-office markers draw from one image fetch; with the image delayed, markers appear once it arrives.