Repository navigation
Run Test and API surface for develop; drop the Firebase deploy - #30
Merged
Merged
Conversation
Both workflows ran only for pull requests to main, so develop could break unseen; it had (stale lockfile, unbuilt dependencies, icon packs outside the workspaces), fixed in #29. They now also run for pull requests to develop, and Test for pushes to it. The basic example is no longer deployed to Firebase Hosting, so its workflow and firebase.json / .firebaserc go.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
main, sodevelopcould break unseen, and it had (fixed in Bump submodules for overlay clickable #29). Both now also run for pull requests todevelop; Test also runs on pushes to it.deploy-basic-example.yml,examples/basic/firebase.jsonand.firebaserc, and a comment that pointed at the workflow.This PR targets develop, so both workflows should run on it.