Repository navigation
Pick the marker drawn under the tap, label included, and size the info bubble by the icon's real extent - #3
Merged
Conversation
…o bubble by the icon's real extent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
タップしたときに「指の下に描かれているマーカー」を選ぶようにしました。js-sdk-core の共通の規則(
pickMarkerHit/preferMarkerHit)を使っています。これまでの判定には 2 つの問題がありました。
今は、通常マーカーとタイル化マーカーを同じ規則で比べます。
あわせて、吹き出しの位置計算を、アイコンの実寸(
markerIconExtentPx)で行うようにしました。ラベルを横や上に置いたときに、吹き出しがずれないようにするためです。依存
確認(develop 上)
npm run buildが通りました。mainは、develop の js-sdk-core に無いMapViewStyleを使っていて、それ単体ではビルドできません(今回の変更とは無関係の既存の状態です)。そのため、js-sdk-react には手元のビルド結果を使いました。