Repository navigation
Move to ios-sdk-core 1.3.2 and fix the sample project - #11
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows the ios-sdk-core 1.3.2 release (MapConductor/ios-sdk-core#13) and the provider PRs that require it.
Submodule pointers
ios-sdk-core→ 08b4d72 (tag1.3.2)from: "1.3.2":Sample app
project.ymland pbxproj pin Google Maps 11.2.0 (was 11.0.0).Both tracked
Package.resolvedfiles are refreshed: ios-maps-sdk 11.2.0, mapbox-maps 11.33.0, maplibre 6.31.0, mappls-api-core 2.1.6. The workspace one was stale (mapbox 11.20.2, maplibre 6.24.0).The pbxproj is regenerated with xcodegen 2.46.0. On develop the sample did not build, failing with
cannot find 'MarkerLabelPositionPage' in scope, because Add a marker label position sample page #10 added the page to the sources without regenerating the project. The regenerated project:../../ios-geojsoninstead of the old../../ios-geojson-layerIt was generated with only the UITests files the develop pbxproj already referenced, so the UITests target is unchanged.
Verified: the MapConductorSampleApp scheme builds for the iOS Simulator (
** BUILD SUCCEEDED **) with this project, core 1.3.2 and every provider branch. Separately, each provider resolvesios-sdk-core @ 1.3.2from GitHub and builds on its own.