Repository navigation
Require ios-sdk-core 1.3.2 - #4
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every provider on develop already declared
from: "1.3.1", but none of them compile against the 1.3.1 tag. They use core API added after it:CameraBearing(clockwise bearing) andMarkerHitTest.pick(labelPosition / tap selection). Resolved through the remote URL, the build failed withcannot find 'CameraBearing' in scope/type 'MarkerHitTest' has no member 'pick'.ios-sdk-core 1.3.2 is now tagged (MapConductor/ios-sdk-core#13), so this raises the minimum to it.
Verified by exporting this branch into a directory with no sibling
../ios-sdk-core, so SwiftPM resolves the core from GitHub: it resolvesios-sdk-core @ 1.3.2andxcodebuild buildfor the iOS Simulator succeeds. The sample app also builds with every provider on these branches.As documented in Package.swift, maps-core 4.0.0 only resolves from a local
../maps-coreclone; the remote-core build was run with that clone present.