Skip to content

fix: re-export domain specific enums #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EllaMartirosyan merged 2 commits into from
Nov 3, 2026
Merged

fix: re-export domain specific enums #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2161b4a
fix: re-export domain specific enums
EllaMartirosyan Nov 3, 2026
bbfdc4f
fix: code review
EllaMartirosyan Nov 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/enums/common/metadata/linkType.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,5 @@
export * from './linkType/common';
export * from './linkType/RasterLinkType';
export * from './linkType/ThreeDLinkType';
export * from './linkType/DemLinkType';
export * from './linkType/VectorLinkType';
4 changes: 4 additions & 0 deletions src/enums/common/metadata/protocolType.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,3 +28,7 @@ export type ProtocolType =
| import('./protocolType/common').PROPRIETARY_DemProtocolType;

export * from './protocolType/common';
export * from './protocolType/RasterProtocolType';
export * from './protocolType/ThreeDProtocolType';
export * from './protocolType/DemProtocolType';
export * from './protocolType/VectorProtocolType';
14 changes: 8 additions & 6 deletions src/enums/common/metadata/sourceType.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
export enum SourceType {
EXTERNAL = 'EXTERNAL',
RASTER_RESOURCE = 'RASTER_RESOURCE',
RESOLVED_RASTER_RESOURCE = 'RESOLVED_RASTER_RESOURCE',
UNRESOLVED_RASTER_RESOURCE = 'UNRESOLVED_RASTER_RESOURCE',
}
/* eslint-disable @typescript-eslint/naming-convention */
export const SourceType = {
RASTER_RESOURCE: 'CATALOG_RESOURCE',
EXTERNAL: 'EXTERNAL',
} as const;

export type SourceType = (typeof SourceType)[keyof typeof SourceType];
/* eslint-enable @typescript-eslint/naming-convention */
4 changes: 0 additions & 4 deletions tests/unit/linkType.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import * as linkTypeModule from '../../src/enums/common/metadata/linkType';

Check warning on line 1 in tests/unit/linkType.spec.ts

View workflow job for this annotation

GitHub Actions / ESLint

tests/unit/linkType.spec.ts#L1 

'linkTypeModule' is defined but never used (@typescript-eslint/no-unused-vars)
import { AssetLinkType, LegendLinkType, ThumbnailLinkType } from '../../src/enums/common/metadata/linkType';

const sorted = (values: string[]): string[] => [...values].sort((a, b) => a.localeCompare(b));
Expand Down Expand Up @@ -37,8 +37,4 @@
it('rejects a value that belongs to none of the exported enums', () => {
expect(Object.values(AssetLinkType)).not.toContain('NOT_A_REAL_LINK_TYPE');
});

it('no longer re-exports the domain-specific link enums (moved to mc-models)', () => {
expect(sorted(Object.keys(linkTypeModule))).toEqual(sorted(['ThumbnailLinkType', 'LegendLinkType', 'AssetLinkType']));
});
});
Loading