13: Leave one repository a newcomer can pick up - #20
Open
CptSchnitz wants to merge 5 commits into
Open
Conversation
CptSchnitz
changed the title
Coverage Report for apps/jobnik-manager
File CoverageNo changed files found. |
Three per-repository Dependabot configs (manager, SDK, e2e) become one `.github/dependabot.yml` at the root. The npm entry uses the new `directories` glob support to cover the root and every app, package and the e2e suite in one block, so upgrades arrive as a single stream of pull requests and a new workspace is picked up automatically rather than needing its own entry. Commit-message prefixes are updated to satisfy this repo's own scope enforcement (`commitlint.config.js`): every Dependabot commit now carries the `deps` scope, which is allowed explicitly for dependency-bump commits that don't name a single workspace. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Documentation generation covers the SDK only -- the manager's public interface is its specification, not its source. Mirrors the reference monorepo's TypeDoc setup: a root `typedoc.json` in "packages" entry mode pointed only at `packages/jobnik-sdk`, that package's own `typedoc.json` carrying over its entry point and tsconfig from the source repository, and a `pnpm docs` script. Output goes to `docs/sdk`, not `docs`, because the repository root's `docs/` already holds the agent-skill domain docs (`docs/agents/`) -- pointing TypeDoc at `docs` directly would let its clean-output-dir step delete them. The GitHub Pages deploy workflow is carried over from the SDK's former repository, adapted to this repo's `init-pnpm` action and scoped to push events touching the SDK or the doc-generation config. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…mand verify From a fresh clone, `pnpm install && pnpm verify` now lints, formats, type-checks, builds and tests every workspace -- one turbo invocation covering the whole task graph, e2e excluded since it needs Docker and runs on its own. The README replaces its placeholder with the workspace layout, that command, and where generated docs and dependency updates now live. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
README and package.json still pointed a newcomer at the archived jobnik-e2e repository: a clone URL for it, an "npm ci"/"npm test" quick start (npm scripts that don't even exist here -- this workspace's task is named "e2e", not "test"), a link to the separate jobnik-manager repository for local setup, and repository/bugs/homepage metadata for jobnik-e2e. All of it now points into this monorepo instead, matching the pattern already used by packages/jobnik-sdk's package.json. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
The spec, stack conventions and all 13 ticket files under .scratch/monorepo-migration/ were the working issue tracker for this migration. With layer 13 landing, the stack is complete and the tracker is done serving its purpose -- remove it rather than leave it as clutter for a newcomer to puzzle over. The .scratch/ convention itself (docs/agents/issue-tracker.md) is unaffected: it's a generic mechanism for future feature work, not specific to this migration. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
CptSchnitz
force-pushed
the
migration/13-housekeeping
branch
from
August 26, 2026 08:17
4e920b0 to
f5379dc
Compare
ronenkapelian
requested changes
Aug 26, 2026
ronenkapelian
left a comment
ronenkapelian
left a comment
There was a problem hiding this comment.
- pr title not according to commitlint
- container_name: 'postgres-for-testing' - two workspaces hardcode the same Docker container name, will couse collusion on running parallel
3.add a root .vscode/settings.json
4.add .gitattributes file (like in opa-la)
5.add .licrc file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Layer 13 of 13, based on
migration/12-e2e-lint. Ticket:.scratch/monorepo-migration/issues/13-housekeeping.md(now removed by this PR — see below).What this does
pnpm install && pnpm verifylints, formats, type-checks, builds and tests every workspace (turbo run format lint type-check build test). e2e is deliberately excluded — it needs Docker and runs on its own (pnpm e2e). README rewritten to describe the workspace layout and this command..github/dependabot.ymlreplaces the three former per-repository Dependabot configs, using the newdirectoriesglob support to cover the root and every app/package/e2e in one block.typedoc.json(packages mode, entry pointpackages/jobnik-sdkonly) + the SDK's owntypedoc.json+ a GitHub Pages deploy workflow scoped to SDK changes. Output goes todocs/sdk, notdocs, since the repo root'sdocs/already holds the agent-skill domain docs.e2e's README andpackage.jsonstill pointed a newcomer at the archivedjobnik-e2erepository (clone URL, annpm testquick start that doesn't match this workspace's actuale2escript, a link to the separatejobnik-managerrepo, and stalerepository/bugs/homepagemetadata). All of it now points into this monorepo, matching the SDK's existing pattern. Service-catalog descriptors were confirmed already dropped when the workspaces were moved in (layer 2)..scratch/monorepo-migration/(spec, stack conventions, all 13 ticket files) served its purpose; deleted so it doesn't sit around as clutter now that the stack is complete. The.scratch/convention itself (docs/agents/issue-tracker.md) is untouched — it's generic, for future feature work.Not in this PR
Verification
pnpm verifypasses clean (17/17 tasks).pnpm docsbuilds SDK docs intodocs/sdkwithout touchingdocs/agents.deps(deps),devdeps(deps),ci(deps)) passcommitlint— checked directly againstcommitlint.config.js's scope enforcement.🤖 Generated with Claude Code