feat(jobnik-sdk): publish from its own tag with packaging and type validation - #12
Open
CptSchnitz wants to merge 1 commit into
Open
feat(jobnik-sdk): publish from its own tag with packaging and type validation#12CptSchnitz wants to merge 1 commit into
CptSchnitz wants to merge 1 commit into
Conversation
…lidation Adds a publish-sdk job to the delivery pipeline, gated on the SDK's own release tag (jobnik-sdk-vX.Y.Z) so pushing the shared jobnik line's tag never triggers it. Packaging and type-resolution are validated first via a new check-pack task (publint, attw --pack, and a script asserting the dry-run pack's own invariants), reachable through turbo like any other task so it can be run before tagging; the job fails before publish if any of them finds a problem. check-pack's own script (scripts/checkPack.mts) asserts what the other two tools don't: that the dry-run pack actually contains the build output and the specification file, and that jobnik-openapi — private, never published — stays out of dependencies/peerDependencies. Wired into scripts/tsconfig.json alongside the package's other two scripts, which is what makes a script in that directory part of the TypeScript project at all. Also points the SDK's package metadata (repository, homepage, bugs) at this repository, with a directory field so the registry page links to the right subfolder — the old jobnik-sdk repository is frozen. check-pack is wired into the PR checks matrix too, so packaging drift is caught on every pull request rather than only at release time.
Coverage Report for apps/jobnik-manager
File CoverageNo changed files found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a publish-sdk job to the delivery pipeline, gated on the SDK's own
release tag (jobnik-sdk-vX.Y.Z) so pushing the shared jobnik line's tag
never triggers it. Packaging and type-resolution are validated first via
a new check-pack task (publint, attw --pack, and a script asserting the
dry-run pack's own invariants), reachable through turbo like any other
task so it can be run before tagging; the job fails before publish if
any of them finds a problem.
check-pack's own script (scripts/checkPack.mts) asserts what the other
two tools don't: that the dry-run pack actually contains the build
output and the specification file, and that jobnik-openapi — private,
never published — stays out of dependencies/peerDependencies. Wired
into scripts/tsconfig.json alongside the package's other two scripts,
which is what makes a script in that directory part of the TypeScript
project at all.
Also points the SDK's package metadata (repository, homepage, bugs) at
this repository, with a directory field so the registry page links to
the right subfolder — the old jobnik-sdk repository is frozen.
check-pack is wired into the PR checks matrix too, so packaging drift
is caught on every pull request rather than only at release time.
Stack created with GitHub Stacks CLI • Give Feedback 💬