fix(helm): set SSL_CERT_FILE alongside REQUESTS_CA_BUNDLE when root-ca is mounted - #99
Merged
Merged
Conversation
…a is mounted Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
razbroc
previously approved these changes
Aug 23, 2026
…iable Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
razbroc
approved these changes
Aug 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SSL_CERT_FILEto the mapproxy container env, right underREQUESTS_CA_BUNDLEandNODE_EXTRA_CA_CERTS, under the same.Values.global.ca.secretNamecondition and pointing at the same mounted root-ca path ({{ global.ca.path }}/{{ global.ca.key }}).Why
REQUESTS_CA_BUNDLEis honored only by therequestslibrary itself. Plainurllib3(used directly by MapProxy's HTTP client) never reads it — verified in practice: TLS sources behind the private CA still failed verification with onlyREQUESTS_CA_BUNDLEset.SSL_CERT_FILEworks one level lower: it is picked up by Python'ssslmodule via OpenSSL's default verify paths. Whenurllib3builds an SSL context without an explicitca_certs, it callsload_default_certs(), which honorsSSL_CERT_FILE— so this covers plainurllib3and anything else falling through tossldefaults (http.client,urllib.request, redis-py TLS, ...).certifiCA file explicitly. If the S3 endpoint uses the private CA,AWS_CA_BUNDLEwould additionally be needed (not part of this PR).Testing
helm lintpasses (pre-existingmclabelsdependency warning only).