docs: correct when the usage report prompt appears in Security - #162
Merged
Conversation
The report bullet said Maintainerr asks once, in the web interface, after a media server is set up. Since Maintainerr#3599 a new install is created with the setting already answered, so it reports from the start and never sees the prompt. Only installs upgrading from a version without the setting are asked, and for them "once" only holds for one of the two buttons: Keep it on saves the answer, while Turn it off in settings saves nothing and only opens the settings page, so the prompt returns on the next visit until the toggle is saved there. One sentence replaced. What the report contains, the TELEMETRY variable and the collector link are unchanged, as is the Installation.mdx row. The versioned snapshots still say no telemetry, which is true for every released version since the report ships in the next one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/Security.mdsaid the usage report prompt is asked once after media server setup. Since Maintainerr#3599 that holds for one button only, and new installs are never asked at all.telemetryEnabled: trueand never see the prompt. Only installs upgrading from a version without the setting (null) are asked, once the media server is set upsettings-data.service.tsseeding,TelemetryConsentModal.tsxpromptingKeep it onsaves the answer and the prompt does not return.Turn it off in settingssaves nothing, it only opens the settings page, so the prompt is back on the next visit until the toggle is saved thereTelemetryConsentModal.tsxkeepOn,onCancelOne sentence replaced in the report bullet. The rest of the bullet, the
TELEMETRYsentence, the collector link and theInstallation.mdxrow are unchanged. Versioned snapshots untouched, since no released version carries the report.Checked against
Maintainerr/Maintainerrdevelopmentate2189f3.npm run formatleft everything else as is,npm run buildis clean.