Skip to content

Add admin bool#72

Merged
AngeloTadeucci merged 1 commit into
MS2Community:masterfrom
Zintixx:admin-bool
May 26, 2026
Merged

Add admin bool#72
AngeloTadeucci merged 1 commit into
MS2Community:masterfrom
Zintixx:admin-bool

Conversation

@Zintixx

@Zintixx Zintixx commented May 26, 2026

Copy link
Copy Markdown

Summary by CodeRabbit

  • New Features

    • Banners now support administrative attributes for enhanced management and control capabilities
  • Chores

    • Package version updated to 2.4.15

Review Change Stack

@coderabbitai

coderabbitai Bot commented May 26, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 886df62d-c1ec-418f-b5af-8342f3ad77cc

📥 Commits

Reviewing files that changed from the base of the PR and between 026ee32 and 4687a50.

📒 Files selected for processing (2)
  • Maple2.File.Parser/Maple2.File.Parser.csproj
  • Maple2.File.Parser/Xml/Table/Banner.cs

📝 Walkthrough

Walkthrough

This PR extends the Banner table schema with a new admin boolean attribute for XML serialization, and bumps the package version from 2.4.14 to 2.4.15 to release the change.

Changes

Banner Admin Attribute and Version Release

Layer / File(s) Summary
Banner admin attribute addition
Maple2.File.Parser/Xml/Table/Banner.cs
Adds public boolean admin property with [XmlAttribute] to Banner class, extending the XML-serialized schema for banner table entries.
Package version release
Maple2.File.Parser/Maple2.File.Parser.csproj
Updates NuGet package version from 2.4.14 to 2.4.15.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Suggested reviewers

  • AngeloTadeucci

Poem

🐰 A banner so bright, now with admin in sight,
Version 2.4.15 takes flight!
One boolean true, a schema so new,
Released with a hop, our package flew! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Add admin bool' accurately describes the main change: adding an admin boolean attribute to the Banner class in the csproj update.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@AngeloTadeucci AngeloTadeucci merged commit 4ed45c1 into MS2Community:master May 26, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants