GWDO2026: Revisions in gravity wave drag scheme (bl_gwdo.F90) by Songyou184 · Pull Request #1409 · MPAS-Dev/MPAS-Model

Songyou184 · 2026-02-10T20:58:54Z

This PR is a part of Revised GWDO + new PBL option for SHIN-HONG scheme #1389

Testing and relations to other Pull Requests should be added as subsequent comments.

See the below examples for more information.
MPAS-Dev/MPAS#930
MPAS-Dev/MPAS#931

modified: core_atmosphere/Registry.xml modified: core_atmosphere/physics/mpas_atmphys_driver_gwdo.F modified: core_atmosphere/physics/mpas_atmphys_driver_sfclayer.F modified: core_atmosphere/physics/mpas_atmphys_vars.F modified: core_atmosphere/physics/physics_wrf/module_bl_gwdo.F modified: core_atmosphere/physics/physics_wrf/module_sf_sfclayrev.F

deleted: core_atmosphere/physics/physics_wrf/module_sf_sfclayrev.F

new file: mpas_atmphys_driver_sfclayer.F new file: physics_wrf/module_sf_sfclayrev.F

modified: src/core_atmosphere/physics/mpas_atmphys_driver.F

…nto GWDO2026 merge branch

jihyeonjang

As noted on Externals.cfg, I think it would be better to use the NCAR/MMM-physics repository, if possible.

Would 20260319-WRFv4.8.0 be the right tag for this PR? Or should we wait for the upcoming tag instead? If the new tag is preferred, when is it expected to be available?

Also, can the upcoming tag, or 20260319-WRFv4.8.0, be used directly with @Songyou184's modified MPAS code in this PR and his other PRs (#1410, #1411)?

I am adding @weiwangncar @dudhia for more input. Thank you!

jihyeonjang · 2026-05-22T03:57:33Z

 protocol = git
-repo_url = https://github.com/NCAR/MMM-physics.git
-tag = 20250616-MPASv8.3
+repo_url = https://github.com/songyou184/MMM-physics.git


This is a private repository rather than the public MMM-physics repository. If possible, I think the branch/tag specified in Externals.cfg should be from https://github.com/NCAR/MMM-physics.git.

@jihyeonjang Since bl_gwdo.F90 in MMM-physics has recently updated, it is now ok to point to that repository. But it may need to update the hash to access the newest code.

@weiwangncar Which MMM-physics tag (or branch) should be used with the MPAS mods for KIM-GWDO and SFCLAY-TOFD? 20260319-WRFv4.8.0?

@islas Should we create a new tag for the WRF release. The last one is out of date compared to the current release branch.

@jihyeonjang Currently the top of the MMM-physics repository is the one, and we will update the tag for WRF release (tag 20260319-WRFv4.8.0 is out-of-date). But perhaps you should create a tag for MPAS release as well.

jihyeonjang · 2026-05-22T04:00:11Z

    sina_p             !sine of map rotation                                                                   [-]

 real(kind=RKIND),dimension(:,:),allocatable:: &
+    ter_p,            &!orographic height                                                                      [m]


ter_p can be deleted? It does not appear to be used anywhere.

jihyeonjang · 2026-05-22T04:17:29Z

+                <nml_option name="config_gwdo_nonhyd" type="logical" default_value="true" in_defaults="true"
+                     units="-"
+                     description="Logical index for nonhydrostatic effect in kim_gwdo scheme"
+                     possible_values="true. or .false."/>


For possible_values, "." is needed before true, so it should be:
possible_values=".true. or .false."

jihyeonjang · 2026-05-22T04:18:28Z

+                     units="-"
+                     description="Effective grid length ratio in kim_gwdo scheme"
+                     possible_values="Non-negative real values"/>
+                <nml_option name="config_gwdo_nonhyd" type="logical" default_value="true" in_defaults="true"


Is it okay to set in_defaults="false" so that config_gwdo_nonhyd is set to true automatically and does not need to be specified by users in namelist.atmosphere, similar to the other physics options?

@Songyou184: In PR #1358, config_gwdo_nonhyd is false by default , but here it is set to true by default. Please confirm its default value.

jihyeonjang · 2026-06-03T05:41:24Z

Related information for this PR was found in the closed PR #1358 as follows:

Update of the YSU_GWD scheme (Choi and Hong 2015, JGR), and renamed it as KIM_GWD scheme. Revisions include sub-grid orographic statistics and configuration of the drag stress and blocking stress, as described in Hong et al. (2025, WAF).

The name of the scheme is "bl_kim_gwdo" instead of "bl_ysu_gwdo".

in "namelist.atmosphere"
&physics
   config_gwdo_nonhyd = true
/
"config_gwdo_nonhyd=true" should result in an overall decrease of GWD stress by less than 10 % over high mountains. A significant reduction appears over the Antarctic.

Songyou184 · 2026-06-03T15:48:58Z

JH: Please set the two parameters = .true. in the Registry. config_gwdo_nonhyd="true" and config_kim_tofd='true' --------------------------------------------------------------------------- These two red configs are defined as "false" by default. "config_kim_gwdo=true" should result in an overall decrease of surface layer wind. "config_gwdo_nonhyd=true" should result in an overall decrease of GWD stress by less than 10 % over high mountains. A significant reduction appears over the Antarctic.

…

On Tue, Jun 2, 2026 at 11:42 PM Jihyeon Jang ***@***.***> wrote: @jihyeonjang commented on this pull request. ________________________________ In src/core_atmosphere/Registry.xml: > @@ -2451,6 +2452,14 @@ units="s" description="Relaxation time to initial values in 1-d OML" possible_values="Non-negative real values"/> + <nml_option name="config_gwdo_factor" type="real" default_value="2.0" in_defaults="false" + units="-" + description="Effective grid length ratio in kim_gwdo scheme" + possible_values="Non-negative real values"/> + <nml_option name="config_gwdo_nonhyd" type="logical" default_value="true" in_defaults="true" @Songyou184: In PR #1358, config_gwdo_nonhyd is false by default , but here it is set to true by default. Please confirm its default value. — Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today! You are receiving this because you were mentioned.Message ID: ***@***.***>

weiwangncar · 2026-06-03T16:34:55Z

@Songyou184 In WRF, kim_tofd is currently set to false. It may be good to do the same in MPAS since it is a newer option, and it may double count surface drag if someone is using the GSL gwdo (correct?).

Songyou184 · 2026-06-03T16:56:44Z

Wei What you described is correct...!!! GSL_Drag can double count for form drag, whereas it is the only form drag in MMM_suite. As you suggested, let's set it = false, and wait for the feedback from the community...

…

On Wed, Jun 3, 2026 at 10:35 AM weiwangncar ***@***.***> wrote: *weiwangncar* left a comment (MPAS-Dev/MPAS-Model#1409) <#1409 (comment)> @Songyou184 <https://github.com/Songyou184> In WRF, kim_tofd is currently set to false. It may be good to do the same in MPAS since it is a newer option, and it may double count surface drag if someone is using the GSL gwdo (correct?). — Reply to this email directly, view it on GitHub <#1409?email_source=notifications&email_token=AVR3U6XM3CFB7KBJU4YEA7T46BHUNA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINRRGQ3DENZVGYY2M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-4614627561>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AVR3U6WECJS6PKESQDI2FFL46BHUNAVCNFSM6AAAAACZIVM4DKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DMMJUGYZDONJWGE> . Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS <https://github.com/notifications/mobile/ios/AVR3U6TGSV6YRVC6PMM2PDL46BHUNA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINRRGQ3DENZVGYY2M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJKTGN5XXIZLSL5UW64Y> and Android <https://github.com/notifications/mobile/android/AVR3U6WRZMWBTNQZWJKGRST46BHUNA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINRRGQ3DENZVGYY2M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI>. Download it today! You are receiving this because you were mentioned.Message ID: ***@***.***>

jihyeonjang · 2026-06-04T01:51:12Z

@Songyou184 I would like to suggest the following modifications:

config_kim_tofd is not introduced in this PR, but in #1410. Could you briefly explain how config_kim_gwdo and config_kim_tofd are related? My understanding is that they are not dependent of each other, since you mentioned that TOFD can be used with GSL GWD.
Could you make the modifications I suggested previously and merge the commit to this PR branch?
Following the discussion above, could you also update Registry.xml in #1410 as follows? I left a review comment there.
<nml_option name="config_kim_tofd" type="logical" default_value="false" in_defaults="false"

Songyou184 · 2026-06-04T03:27:56Z

kim_gwdo has a new component of a turbulent orographic form drag (TOFD), which was absent in the ysu_gwdo. It adds a roughness length in computing exchange coefficient in SFCLAY. config_kim_tofd is the option for that. It is a part of kim_gwdo, but practically iis located in the SFCLAY routine..It is a new component, thus, set to = false. by default. In the coming version, it can be set = .true.

…

On Wed, Jun 3, 2026 at 7:51 PM Jihyeon Jang ***@***.***> wrote: *jihyeonjang* left a comment (MPAS-Dev/MPAS-Model#1409) <#1409 (comment)> @Songyou184 <https://github.com/Songyou184> I would like to suggest the following modifications: - config_kim_tofd is not introduced in this PR, but in #1410 <#1410>. Could you briefly explain how config_kim_gwdo and config_kim_tofd are related? My understanding is that they are not dependent of each other, since you mentioned that TOFD can be used with GSL GWD. - Could you make the modifications I suggested previously and merge the commit to this PR branch? - Following the discussion above, could you also update Registry.xml in #1410 <#1410> as follows? I left a review comment there. <nml_option name="config_kim_tofd" type="logical" default_value="false" in_defaults="false" — Reply to this email directly, view it on GitHub <#1409?email_source=notifications&email_token=AVR3U6TBMEHOH4WRWNDZ6MD46DI2PA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINRRHAZDMNJUGY3KM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-4618265466>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AVR3U6STDOWTARTJAS3PS5L46DI2PAVCNFSM6AAAAACZIVM4DKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DMMJYGI3DKNBWGY> . Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS <https://github.com/notifications/mobile/ios/AVR3U6VIIGZO2BPBINTOX7T46DI2PA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINRRHAZDMNJUGY3KM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJKTGN5XXIZLSL5UW64Y> and Android <https://github.com/notifications/mobile/android/AVR3U6UETNJPVOVIRLTM2ED46DI2PA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINRRHAZDMNJUGY3KM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI>. Download it today! You are receiving this because you were mentioned.Message ID: ***@***.***>

Songyou184 · 2026-06-04T15:56:00Z

It should point to https://github.com/NCAR/MMM-physics.git <https://github.com/NCAR/MMM-physics.git-tag> repository...I guess

…

On Thu, Jun 4, 2026 at 9:42 AM dudhia ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In src/core_atmosphere/Externals.cfg <#1409 (comment)>: > @@ -1,8 +1,8 @@ [MMM-physics] local_path = ./physics_mmm protocol = git -repo_url = https://github.com/NCAR/MMM-physics.git -tag <https://github.com/NCAR/MMM-physics.git-tag> = 20250616-MPASv8.3 +repo_url = https://github.com/songyou184/MMM-physics.git @islas <https://github.com/islas> Should we create a new tag for the WRF release. The last one is out of date compared to the current release branch. — Reply to this email directly, view it on GitHub <#1409?email_source=notifications&email_token=AVR3U6UQ4OH4WUR32QYJMOL46GKF5A5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTINBSHEZDKMJVGY2KM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#discussion_r3357199103>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AVR3U6X6LBV2JQEYW3OYTJT46GKF5AVCNFSM6AAAAACZIVM4DKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHM2DIMRZGI2TCNJWGQ> . Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS <https://github.com/notifications/mobile/ios/AVR3U6TGBOQAO7YE5ZFSITD46GKF5A5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTINBSHEZDKMJVGY2KM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJKTGN5XXIZLSL5UW64Y> and Android <https://github.com/notifications/mobile/android/AVR3U6V5YADW4N37BM2473D46GKF5A5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTINBSHEZDKMJVGY2KM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI>. Download it today! You are receiving this because you were mentioned.Message ID: ***@***.***>

Songyou184 · 2026-06-04T15:59:47Z

I believe the main branch is the one.. https://github.com/NCAR/MMM-physics/tree/main

…

On Thu, Jun 4, 2026 at 12:35 AM Jihyeon Jang ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In src/core_atmosphere/Externals.cfg <#1409 (comment)>: > @@ -1,8 +1,8 @@ [MMM-physics] local_path = ./physics_mmm protocol = git -repo_url = https://github.com/NCAR/MMM-physics.git -tag <https://github.com/NCAR/MMM-physics.git-tag> = 20250616-MPASv8.3 +repo_url = https://github.com/songyou184/MMM-physics.git @weiwangncar <https://github.com/weiwangncar> Which MMM-physics tag (or branch) should I use with the MPAS mods for KIM-GWDO and SFCLAY-TOFD? 20260319-WRFv4.8.0? — Reply to this email directly, view it on GitHub <#1409?email_source=notifications&email_token=AVR3U6REWKIIGG4BKE2ISVL46EKB5A5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTINBSGU2DGNJTGAY2M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#discussion_r3353988446>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AVR3U6Q5SSDUJJZPK65LGID46EKB5AVCNFSM6AAAAACZIVM4DKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHM2DIMRVGQZTKMZQGE> . Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS <https://github.com/notifications/mobile/ios/AVR3U6WAYDIBZWDOEJ3IUKD46EKB5A5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTINBSGU2DGNJTGAY2M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJKTGN5XXIZLSL5UW64Y> and Android <https://github.com/notifications/mobile/android/AVR3U6XAH3HCAGPSCWXOMQL46EKB5A5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTINBSGU2DGNJTGAY2M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI>. Download it today! You are receiving this because you were mentioned.Message ID: ***@***.***>

Songyou184 added 12 commits February 9, 2026 14:44

SFCLAY: turbulent orographic form drag (TOFD):

091b104

modified: src/core_atmosphere/Externals.cfg

7c74580

deleted: core_atmosphere/physics/mpas_atmphys_driver_sfclayer.F

18aa12f

deleted: core_atmosphere/physics/physics_wrf/module_sf_sfclayrev.F

restore master file

fccc7fb

new file: mpas_atmphys_driver_sfclayer.F new file: physics_wrf/module_sf_sfclayrev.F

modified: physics/mpas_atmphys_control.F

879df95

modified: mpas_atmphys_driver_gwdo.F

8b7a88d

modified: mpas_atmphys_driver_gwdo.F

5962200

modified: mpas_atmphys_driver_gwdo.F

2a95973

modified: src/core_atmosphere/Registry.xml

0e4db6d

modified: src/core_atmosphere/physics/mpas_atmphys_driver.F

Merge branch 'GWDO2026' of https://github.com/Songyou184/MPAS-Model i…

75e7cfb

…nto GWDO2026 merge branch

remove unnecessary files

eb18414

jihyeonjang self-requested a review May 22, 2026 03:38

jihyeonjang suggested changes May 22, 2026

View reviewed changes

jihyeonjang mentioned this pull request Jun 4, 2026

SFCLAY2026 : Adding a surface layer based TOFD scheme #1410

Open

Conversation

Songyou184 commented Feb 10, 2026

Uh oh!

jihyeonjang left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jihyeonjang May 22, 2026

Choose a reason for hiding this comment

Uh oh!

weiwangncar May 22, 2026

Choose a reason for hiding this comment

Uh oh!

jihyeonjang Jun 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dudhia Jun 4, 2026

Choose a reason for hiding this comment

Uh oh!

weiwangncar Jun 4, 2026

Choose a reason for hiding this comment

Uh oh!

jihyeonjang May 22, 2026

Choose a reason for hiding this comment

Uh oh!

jihyeonjang May 22, 2026

Choose a reason for hiding this comment

Uh oh!

jihyeonjang May 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jihyeonjang Jun 3, 2026

Choose a reason for hiding this comment

Uh oh!

jihyeonjang commented Jun 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Songyou184 commented Jun 3, 2026 via email

Uh oh!

weiwangncar commented Jun 3, 2026

Uh oh!

Songyou184 commented Jun 3, 2026 via email

Uh oh!

jihyeonjang commented Jun 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Songyou184 commented Jun 4, 2026 via email

Uh oh!

Songyou184 commented Jun 4, 2026 via email

Uh oh!

Songyou184 commented Jun 4, 2026 via email

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jihyeonjang left a comment •

edited

Loading

jihyeonjang Jun 4, 2026 •

edited

Loading

jihyeonjang May 22, 2026 •

edited

Loading

jihyeonjang commented Jun 3, 2026 •

edited

Loading

jihyeonjang commented Jun 4, 2026 •

edited

Loading