INIT_GWDO: Revisions in computing mountain statistics

[Songyou184]

modified:   src/core_init_atmosphere/mpas_init_atm_gwd.F

This PR is a part of Revised GWDO + new PBL option for SHIN-HONG scheme #1389

See the below examples for more information.
MPAS-Dev/MPAS#930
MPAS-Dev/MPAS#931

[jihyeonjang]

This PR looks fine to me. I only have a minor suggestion for clean-up.

In this PR, hc (critical height) is no longer used; box_mean is used instead. In src/core_init_atmosphere/mpas_init_atm_gwd.F, can we comment out hc-related lines as follows?

    integer (kind=I1KIND), dimension(:), pointer :: hlanduse ! Dominant land mask (0 or 1)
-   real (kind=RKIND) :: hc   ! critical height
+   !real (kind=RKIND) :: hc   ! critical height

    contains

@@ -301,7 +301,7 @@ module mpas_init_atm_gwd
          ! Critical height, to be used in OL computation
          ! See Appendix of Kim, Y-J, 1996: Representation of Sub-Grid Scale Orographic Effects
          ! in a General Circulation Model. J. Climate, 9, 2698-2717.
-         hc = 1116.2_RKIND - 0.878_RKIND * var2d(iCell)
+         !hc = 1116.2_RKIND - 0.878_RKIND * var2d(iCell)

[Songyou184]

Yes, hc is no longer used...

…

On Wed, Jun 3, 2026 at 9:12 PM Jihyeon Jang ***@***.***> wrote: ***@***.**** approved this pull request. This PR looks fine to me. I only have a minor suggestion for clean-up. In this PR, hc (critical height) is no longer used; box_mean is used instead. In src/core_init_atmosphere/mpas_init_atm_gwd.F, can we comment out hc-related lines as follows? integer (kind=I1KIND), dimension(:), pointer :: hlanduse ! Dominant land mask (0 or 1) - real (kind=RKIND) :: hc ! critical height + !real (kind=RKIND) :: hc ! critical height contains @@ -301,7 +301,7 @@ module mpas_init_atm_gwd ! Critical height, to be used in OL computation ! See Appendix of Kim, Y-J, 1996: Representation of Sub-Grid Scale Orographic Effects ! in a General Circulation Model. J. Climate, 9, 2698-2717. - hc = 1116.2_RKIND - 0.878_RKIND * var2d(iCell) + !hc = 1116.2_RKIND - 0.878_RKIND * var2d(iCell) — Reply to this email directly, view it on GitHub <#1408?email_source=notifications&email_token=AVR3U6SWIWUCBD7ZSEIIHRD46DSJRA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTINBSGQZTENBUGA3KM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#pullrequestreview-4424324406>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AVR3U6UOGVLF6O3ZTHPXWVT46DSJRAVCNFSM6AAAAACZZV5B2WVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHM2DIMRUGMZDINBQGY> . Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS <https://github.com/notifications/mobile/ios/AVR3U6QEZZHKGMUDBBQBTLD46DSJRA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTINBSGQZTENBUGA3KM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KUZTPN52GK4S7NFXXG> and Android <https://github.com/notifications/mobile/android/AVR3U6T52XHQLMBY7OC4B7346DSJRA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTINBSGQZTENBUGA3KM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2K4ZTPN52GK4S7MFXGI4TPNFSA>. Download it today! You are receiving this because you authored the thread.Message ID: ***@***.***>